Soulshape Journal

Soulshape Journal

176k Downloads

Issues with "MountsJournal" and "Beast Squads" addons

LadyAtia opened this issue ยท 9 comments

commented

Heyo :)

Currently your addon isn't working alongside thouse two. In the case of MountsJournal i can't see your soulshape page if I have it active, while Beast Squads tab is under your soulshape tap. I can give you screenshots if you need.

commented

Also, would it be possible to add filters for the normal and small soulshapes, aswell as an option to tag them (and the option to hide specific tags).

I love the idea of your addon so please keep working on it :)

commented
commented

Hello, yes the bug with MountsJournal has been fixed, but that fix will be available in version 0.9. I still have a few things to do before I publish 0.9, the full list is here. I'll try to do this before the end of the week, hopefully tomorrow.

commented

@LadyAtia 0.9 is out on CurseForge, you should be able to use it with MountsJournal.

commented

Hello, I'm on a trip abroad and will be investingating issues asap.
Thanks for the reporting.

AFAIK, addons use different ways of adding a new tab to the collection journal that may not be compatible, I'll see if I can find something that works properly.

commented

@LadyAtia Adding more filters, like soulshape/crittershape is already planned.

I'm going to investigate the interaction with MountsJournal, however I couldn't find an addon named "Beast Squads", it's probably a feature from another or pack, but I couldn't find it.

commented

I believe this may be the addon they're referring to when they say "Beast Squad": https://www.curseforge.com/wow/addons/istablemaster

commented

Thank you, I'll look into it.

commented

OK, seems that iStableMaster implemented their own tab-handling logic, which unfortunately is not compatible with the way I chose (lib SecureTabs-2.0). There is no standard way of adding a new tab+panel to an existing default UI panel (here it's the Collections Journal), which means that addons using two different methods won't see each other's tabs and they will overlap.

The only possible fix here would be that iStableMaster uses lib SecureTabs-2.0 to handle their tabs, but I'm not exactly in a position to ask that from them ๐Ÿ˜…

I'll document this known incompatibility in the readme and I'll close this.