SweepyBoop's Arena Helper

SweepyBoop's Arena Helper

43.1k Downloads

For resetSpells, even with cd reduction, icon stays on with no timer when it expires

SweepyBoop opened this issue ยท 9 comments

commented
commented

Auto hide seems broken for certain spells, like HOJ, combustion

commented

Should I start a new allstates[guid] instead of updating current one for reset spells?
Updating the expirationTime only seems broken.

commented

old HOJ timer allstate:

            show = true,
            changed = true,
            progressType = "timed",
            duration = cooldown,
            expirationTime = GetTime() + cooldown,
            autoHide = true,
commented

The old HOJ timer doesn't have the same issue.

commented

The old HOJ timer doesn't have the extra members in the allstates

commented

Need to differentiate the makeState helper functions.

commented

makeAllState makes:
show = true,
changed = true,
progressType = "timed",
duration = duration,
expirationTime = GetTime() + duration,
icon = select(3, GetSpellInfo(spellID)),
sound = spellData.sound,
index = spellData.index or defaultIndex,
stacks = charges,
unit = unit,
autoHide = true,

commented

It's due to typo in reset spell, state.change = true
should be state.changed = true

commented

Fixed in #2