Syling Tracker

Syling Tracker

28.6k Downloads

[Cataclysm Classic] autocomplete quest popup not working

Road-block opened this issue ยท 6 comments

commented

Describe the bug
Some quests get an autocomplete popup on the tracker (Blizz) where you can complete them "on the go".

Do you have an error log of what happened?
If you don't see any errors, make sure that error reporting is enabled (/console scriptErrors 1) or install BugSack.
There are no Lua errors, this must be an implementation/logical bug.

To Reproduce
Steps to reproduce the behavior:
Example quest.

  1. Got Guardians of Hyjal: Call of the Ancients
  2. Completed quest.
  3. With Syling Tracker enabled I have no way to turn in (no popup and click not working)
  4. Disabling the addon I get the popup on the default Blizzard tracker.

Expected behavior
It would be nice to quest seamlessly without having to disable/reload to turn in autocomplete quests

Screenshots
Default Tracker
image
Syling Tracker
image

What is the version of SylingTracker you use ?
v2.5.2

What are the versions of PLoop and Scorpio you use ?

  • PLoop: 'Put the version here'
  • Scorpio: r221

Additional context
Add any other context about the problem here.

commented

Hello,

The auto quests module was missing, so i took the one from Retail and made the necessary conversions to use the Cataclysm API. This should display the popups in the tracker.

Since i'm not a Cataclysm player and haven't been able to verify this on the PTR, i'm not 100% sure if everything is okay.

Thank you for the information provided, it's really a time-saver. In the future, if you can don't hesitate to send me a pull request.

commented

Having done the dailies for a couple days with this fix in place it works fine but it definitely needs some kind of indicator for people that play without sound on.

So you know you can click the completed quest to autodeliver and spawn the followup.

Edit: I'll try the 2.5.3 tag on a fresh character since it's a different implementation ๐Ÿ˜ƒ

commented

2.5.3 popup works fine ๐Ÿ‘๐Ÿป

This can be closed.

commented

There is a slightly better workaround than disabling the addon.

Can temporarily toggle the "show blizzard objective tracker" from the options, but that is not ideal either ๐Ÿ™‚

commented

Following changes will stop errors and let us at least click to complete as intended. (I'd still prefer some kind of popup to make it obvious)
Or a "click to complete" indicator like the default tracker has, that would also work well after the base functionality is working.

/Cataclysm/Contents/Quests/Quests.lua#L31
add

GetQuestLogIsAutoComplete           = GetQuestLogIsAutoComplete,

/Cataclysm/Contents/Quests/Quests.lua#L80
add

local isAutoComplete = GetQuestLogIsAutoComplete(i)

/Cataclysm/Contents/Quests/Quests.lua#L114
replace questData.isAutoComplete = nil -- TODO: Need check it with

questData.isAutoComplete = isAutoComplete

/Cataclysm/Contents/Quests/Quests.lua#L124
same treatment inside the while loop add

isAutoComplete = GetQuestLogIsAutoComplete(i)

Similar changes for function UpdateQuest
/Cataclysm/Contents/Quests/Quests.lua#L158
add

local isAutoComplete = GetQuestLogIsAutoComplete(questLogIndex)

and /Cataclysm/Contents/Quests/Quests.lua#L189
replace the hardcoded = false with

questData.isAutoComplete = isAutoComplete
commented

Additionally for the 2 click handlers (header + content) in Cataclysm/Contents/Quests/QuestView.lua

Under /Cataclysm/Contents/Quests/QuestView.lua#L123
insert

local questLogIndex = GetQuestLogIndexByID(questID)

Replace the two lines at /Cataclysm/Contents/Quests/QuestView.lua#L133 + 134
with

RemoveAutoQuestPopUp(questID)
ShowQuestComplete(questLogIndex)

Repeat for the other click handler
/Cataclysm/Contents/Quests/QuestView.lua#L166
insert new line with

local questLogIndex = GetQuestLogIndexByID(questID)

Replace the two lines at /Cataclysm/Contents/Quests/QuestView.lua#L176 + 177
with

RemoveAutoQuestPopUp(questID)
ShowQuestComplete(questLogIndex)