Talented Classic

Talented Classic

519k Downloads

WOTLK - Death Knight Talent Support

maximus210793 opened this issue ยท 12 comments

commented

Hi,
can you add support for WOTLK Death Knights Talents please?
Thanks a lot..

commented

As far as I know, this is already supported. What are you seeing?

commented

I get the following error, I already reinstalled addon etc.:
[14:03:23] Talented: Talented cannot perform the required action because it does not have the required talent data available for class DEATHKNIGHT.
[14:03:23] Talented: You must enable the Talented_Data helper addon for this action to work.
[14:03:23] Talented: If Talented_Data is out of date, you must update or you can allow it to load outdated data in the settings.
[14:03:25] Questie: Current active phase of Isle of Quel'Danas is 'Phase 1 - Sun's Reach Sanctum'. Check the General settings to change the phase or disable this message.
[14:03:28] Talented: Talented cannot perform the required action because it does not have the required talent data available for class DEATHKNIGHT.
[14:03:28] Talented: You must enable the Talented_Data helper addon for this action to work.
[14:03:28] Talented: If Talented_Data is out of date, you must update or you can allow it to load outdated data in the settings.

commented

I get the same problem.

commented

How did you install the addon? The deathknight talents are literally there, so I'm not sure what to say. However, I have seen multiple reports of this problem. It seems to me like one or more of the repositories (like Curse or WoWUp) are not updating Talented_Data.
image

commented

The WowUpHub is the TBC version, which is strictly wrong. No idea why wago.io is giving you the wrong version, though. I'll try and look into it in a few hours.

commented

image

Looks like the culprit (or one of the culprits) is WowUp. It shows that it is updated the TalentedData folder, but, its data is old.

commented

Talented_Data no longer exists in current releases. You can delete it. I'm surprised WoWUp didn't.
Edit: I realise this contradicts my previous comment, but that's because I updated code to remove the folder two days ago ๐Ÿ˜….

commented

I also notice that WoWUp is indicating "TBC" there. Is it definitely downloading the WotLK version?

commented

image

LOL -- cool -- it is not downloading the correct version. I was just looking into that, it has a broken link for the newest version, and, seems to be picking out an older release for their database.

https://addons.wago.io/addons/talentedclassic/versions?stability=stable

commented

Thanks. Fixed, probably. Still haven't worked out what wago.io is looking for to automatically tag things as WotLK. However, that problem with wago.io should only have appeared this morning, because I changed the tag on the release. Any issues from before about 4 hours ago should be unrelated.

commented

Nice! I can see that it is fixed. Unfortunately, WowUp is still downloading the wrong version (as before). If I direct WowUp to use the WowUpHub (vs Wago), it works but it downloads the version from a couple days ago (220823) ~ which compared to 210718 ~ is a big improvement, lol. Suppose it might take a bit for their database to update.

Keeps getting weirder and weirder. That version downloaded also is broken.. ๐Ÿฒ
The version downloaded directly from GitHub works great! Wow, someone should make a 'new' add-on aggregator to fix all these issues. obligatory: https://xkcd.com/927/