Talented Classic

Talented Classic

519k Downloads

Broken tooltips

Drevil-Dion opened this issue ยท 30 comments

commented

When talented for wrath classic and Zygor guides are both enabled tooltips for items players and everything are constnatly flashing upon disabling talented tooltips return to normal.

Talented disabled
image

Talented enabled
image

Here is a gif showing the tooltip issue

No errors are shown at all had to manually go through addons one by one to find the cause which is only happening when Zygor guides and Talented are enabled.

Here is a screenshot of the talented.toc files showing which version i have which is v221207-WotLK uploaded to curse on Dec 7, 2022
image

commented

Any ETA on a release with this fix built in?

commented

Any ETA on a release with this fix built in?

I'm unlikely to get to this within the next year or so, since I have problems intrinsic to the addon to deal with first and I've only played the game for a week since WotLK released. But hopefully I'll get to it eventually.

Takes a few moments to edit out the lines manually.

commented

I can confirm it breaks tooltips.

Specially if you have zygor installed too.

Glad to know its not just me then Seems to have only happened with the latest update to p2 of wrath where they have introduced code from retail client to enable things like Heroic+

commented

Strange. I don't think I'm touching tooltips. Do many people use Zygor's addon?

commented

I can confirm it breaks tooltips.

Specially if you have zygor installed too.

commented

Strange. I don't think I'm touching tooltips. Do many people use Zygor's addon?

Lot of players use zygor along with other similar add-ons like restedxp, rested however do not cause issues took me over a hour to figure out it was talented causing the issue due to the number of add-ons I have.

commented

Shows how big of a player base uses zygor avg salary for people working for them is 47k USD a year per person 7+ people employed it costs a sub of 9.99 USD a month or 100 USD for the year .

https://i.imgur.com/ndNzt2O.png

commented

Strange. I don't think I'm touching tooltips. Do many people use Zygor's addon?

Yes Zygor is big, paid addon for guides, its been around since the the old Retail late TBC where carbonite got left in the dust.

Let me know if you need a test version to test with.

commented

Strange. I don't think I'm touching tooltips. Do many people use Zygor's addon?

Yes Zygor is big, paid addon for guides, its been around since the the old Retail late TBC where carbonite got left in the dust.

Let me know if you need a test version to test with.

Free version can be downloaded from zygors site to test with
https://zygorguides.com/join

commented

This'll probably take extensive testing, since I don't actually do anything to tooltips in Talented. I'm unlikely to get to this within the next year or so, since I have problems intrinsic to the addon to deal with first and I've only played the game for a week since WotLK released. But hopefully I'll get to it eventually.

commented

This'll probably take extensive testing, since I don't actually do anything to tooltips in Talented. I'm unlikely to get to this within the next year or so, since I have problems intrinsic to the addon to deal with first and I've only played the game for a week since WotLK released. But hopefully I'll get to it eventually.

Just a thought.

Could you try release a version in this thread with latest libs available to see if there's something there that collides?

I can test right away.

commented

I've deleted all of the folders in /Libs and it works again. So yea, probably outdated Libs?

commented

Ah, great. Thanks for that, it might've taken me a while to think of looking at the libraries. I'll see to that ASAP, maybe when/if I get a free moment this evening ๐Ÿ˜Š

commented

It seems you don't need to delete the Talented>Libs folder completely, preventing LibGratuity-3.0 from being loaded worked for me.

Open Talented.toc and comment out this line:

Libs\LibGratuity-3.0\LibGratuity-3.0.lua

From what I can tell it doesn't affect the functionality of the addon.

Can confirm this works talented loaded and zygor and tooltips showing perfect

image

commented

It seems you don't need to delete the Talented>Libs folder completely, preventing LibGratuity-3.0 from being loaded worked for me.

Open Talented.toc and comment out this line:

Libs\LibGratuity-3.0\LibGratuity-3.0.lua

From what I can tell it doesn't affect the functionality of the addon.

commented

Hello, I've pushed an update. Could you let me know if it worked?

commented

Can confirm about tooltip issue and about fix. Thanks guys!

commented

can confirm the issue repro and the manual fix by commenting out the line worked on version from 12/7/2022

commented

Ack. Doesn't look hard to fix but I'll need to be able to boot the game to debug it. Bear with me. Life's a bit busy, hence why I tried to go for the "easy" route of pushing without a test.

Incidentally, the only change I made since the last time I played the game myself was to delete LibGratuity. I simply had some uncommitted updates (namely, updating all the Ace libraries). So, it's a bit mystifying that it didn't work.

commented

Hello, I've pushed an update. Could you let me know if it worked?

No not working.

Each line represent a new error popup, I took the copy paste from bugsack addon and posted here.

`1x Interface_Wrath\FrameXML\Bindings.xml:54 Error loading Talented/IndexMatching.lua

1x Interface_Wrath\FrameXML\Bindings.xml:55 Error loading Talented/spelldata.lua

1x Interface_Wrath\FrameXML\Bindings.xml:66 Error loading Talented/ui/roleselect.lua

1x Interface_Wrath\FrameXML\Bindings.xml:68 Error loading Talented/pet.lua

1x Interface_Wrath\FrameXML\Bindings.xml:69 Error loading Talented/glyph.lua

1x Interface_Wrath\FrameXML\Bindings.xml:1 Interface_Wrath\FrameXML\Bindings.xml:54 Error loading Talented/IndexMatching.lua

1x Interface_Wrath\FrameXML\Bindings.xml:1 Interface_Wrath\FrameXML\Bindings.xml:54 Error loading Talented/IndexMatching.lua

1x Interface_Wrath\FrameXML\Bindings.xml:1 Interface_Wrath\FrameXML\Bindings.xml:55 Error loading Talented/spelldata.lua

1x Interface_Wrath\FrameXML\Bindings.xml:1 Interface_Wrath\FrameXML\Bindings.xml:66 Error loading Talented/ui/roleselect.lua

1x Interface_Wrath\FrameXML\Bindings.xml:1 Interface_Wrath\FrameXML\Bindings.xml:68 Error loading Talented/pet.lua

8x Talented/spell.lua:106: attempt to index field 'spelldata' (a nil value)
[string "@Talented/spell.lua"]:106: in function UncompressSpellData' [string "@Talented/viewmode.lua"]:16: in function UpdatePlayerSpecs'
[string "@Talented/core.lua"]:377: in function Update' [string "@Talented/core.lua"]:362: in function <Talented/core.lua:359> [string "=(tail call)"]: ? [string "=[C]"]: in function ToggleTalentFrame'
[string "TOGGLETALENTS"]:1: in function <[string "TOGGLETALENTS"]:1>

Locals:
self =

{
CreateTemplateMenu = defined @Talented/ui/menu.lua:65
defaults =
{
}
LoadAddOn = defined @Talented/core.lua:76
OpenOptionsFrame = defined @Talented/ui/menu.lua:26
MakeArrow = defined @Talented/ui/arrows.lua:17
GetTalentPrereqs = defined @Talented/spell.lua:213
UnregisterComm = defined @AtlasLootClassic/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:143
HideTooltipInfo = defined @Talented/tips.lua:103
GetDefaultMode = defined @Talented/core.lua:293
SetDefaultModulePrototype = defined @Atlas/Libs/AceAddon-3.0/AceAddon-3.0.lua:405
UpdateTemplateName = defined @Talented/core.lua:128
GetMode = defined @Talented/core.lua:56
SetTemplate = defined @Talented/core.lua:269
SetMode = defined @Talented/core.lua:60
RegisterMessage = defined @AtlasLootClassic/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:80
UnregisterMessage = defined @AtlasLootClassic/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:143
Update = defined @Talented/core.lua:375
hooks =
{
}
SendCommMessage = defined @AtlasLootClassic/Libs/AceComm-3.0/AceComm-3.0.lua:83
db =
{
}
UnregisterAllComm = defined @AtlasLootClassic/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:164
SetEnabledState = defined @Atlas/Libs/AceAddon-3.0/AceAddon-3.0.lua:420
Hook = defined @Decursive/Libs/AceHook-3.0/AceHook-3.0.lua:273
OpenTemplate = defined @Talented/core.lua:249
OnEnable = defined @Talented/core.lua:297
GetTemplateStringClass = defined @Talented/encode.lua:15
MakeButton = defined @Talented/ui/buttons.lua:75
ImportTemplate = defined @Talented/core.lua:214
Pool =
{
}
UnregisterAllEvents = defined @AtlasLootClassic/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:164
optionsFrame = Frame {
}
Deserialize = defined @BugSack/Libs/AceSerializer-3.0/AceSerializer-3.0.lua:246
MakeActionMenu = defined @Talented/ui/menu.lua:396
TalentView =
{
}
GetName = defined @Atlas/Libs/AceAddon-3.0/AceAddon-3.0.lua:275
views =
{
}
name = "Talented"
UpdateView = defined @Talented/viewmode.lua:58
Disable = defined @Atlas/Libs/AceAddon-3.0/AceAddon-3.0.lua:310
GetOption = defined @Talented/options.lua:66
Unhook = defined @Decursive/Libs/AceHook-3.0/AceHook-3.0.lua:417
Print = defined @Talented/core.lua:7
UncompressSpellData = defined @Talented/spell.lua:94
SetOption = defined @Talented/options.lua:59
Serialize = defined @BugSack/Libs/AceSerializer-3.0/AceSerializer-3.0.lua:122
Debug = defined @Talented/core.lua:15
EnableUI = defined @Talented/ui/base.lua:393
MakeTalentFrame = defined @Talented/ui/trees.lua:99
RegisterComm = defined @AtlasLootClassic/Libs/AceComm-3.0/AceComm-3.0.lua:56
PLAYER_TALENT_UPDATE = defined @Talented/core.lua:318
CopyTemplate = defined @Talented/core.lua:186
tabs = Frame {
}
MakeBranch = defined @Talented/ui/branches.lua:17
IsTemplateAtCap = <`

commented

Ack. Doesn't look hard to fix but I'll need to be able to boot the game to debug it. Bear with me. Life's a bit busy, hence why I tried to go for the "easy" route of pushing without a test.

Incidentally, the only change I made since the last time I played the game myself was to delete LibGratuity. I simply had some uncommitted updates (namely, updating all the Ace libraries). So, it's a bit mystifying that it didn't work.

I would just push a update with those line myself and others have manually deleted for the time being since deleting them I have not had any issues at all

commented

It works perfectly fine with the LibGratuity lib removed from Talented.toc, can you push an update with this? The lib does not seem to be used anywhere in talented (except commented out code).

commented

I've been away for a while and just got to testing this ingame myself. It worked perfectly. I even went and signed up to Zygor and installed their application, and it still worked.

Then I went and had a look to see if the github files were somehow different.
...Yes, for quite some time, I'd had some files accidentally on gitgnore. This'll probably fix lot of things that've been broken for a while. Could someone test it again, to make sure it's not just me?

commented

I've been away for a while and just got to testing this ingame myself. It worked perfectly. I even went and signed up to Zygor and installed their application, and it still worked.

Then I went and had a look to see if the github files were somehow different. ...Yes, for quite some time, I'd had some files accidentally on gitgnore. This'll probably fix lot of things that've been broken for a while. Could someone test it again, to make sure it's not just me?

I just did a new test and this version you put it does not have any issues so far.

commented

Fabulous, I'll make it a release tomorrow. Thank you.

commented

On what version of the game and with which version of the addon? Did it work with a previous version?

commented

This is still present :(

commented

I am a new user so not very sure.

Currently using latest version of Zygor Version: 1.1.29966 and v231130-Era

Let me try version v230930-Era

commented

Still happening with v230930-Era aswell

commented

Aha. It was a problem with the WotLK version which we then fixed. Apparently it's here with the Era version too. It's related to LibGratuity but unfortunately LibGratuity is required for the Era version of the addon without a rewrite. The rewrite required functions that WotLK has but Vanilla doesn't. I'll have to see if it's possible to use something other than LibGratuity.