Not working in KR client
mark251 opened this issue · 13 comments
I don't know if this is how tb setting is supposed to look like
but it seems to be not working in KR client enven Tankbuddy is enabled / announcement is enabled.
Could you please help
Thanks
L["Auras"] = {["Salvation"] = "구원의 축복", ["RF"] = "정의의 격노"}
L["Abilities"] = {
["CR"] = {
["Name"] = "도전의 포효",
},
["CS"] = {
["Name"] = "도전의 외침",
},
["FR"] = {["Name"] = "마의 분노", ["Default"] = "", ["Prompt"] = ""},
["Growl"] = {
["Name"] = "포효",
},
["LS"] = {
["Name"] = "최후의 저항",
},
["MB"] = {
["Name"] = "도발의 일격",
},
["RD"] = {
["Name"] = "정의의 방어",
},
["SW"] = {
["Name"] = "방패의 벽",
},
["Taunt"] = {
["Name"] = "도발",
}
}
I searched every skill in wowhead(tbc) and replaced them with KR skill names.
I wasn't sure about Salvation(which is supposed to be Blessing of Salvation) and Fel Rage.
Please let me know if I have to change something else.
Thanks
koKR is not supported yet. https://github.com/valkyrnstudios/TankBuddy/tree/main/locale
Please submit a pull request or comment here with a krKR file like, enUS
Thank you for you reply.
I don't understand what file im supposed to upload.
I tried to find krkr.lua file in my wow folder but could not find anything.
Im new to github so please explain what file Im supposed to upload.
thank you,
You need to write one to translate everything to Korean. Like L["Done"] = "완료"; (per Google Translate).
L["DisableInBG"] = "Disable in battlegrounds";
L["Done"] = "완료";
L["EnableTankBuddy"] = "Enable Tank Buddy";
L["EnterNewMBRecoveryText"] =
"Enter new announcement text for recovered taunts:";
L["General"] = "General";
L["Help"] = "Help";
L["output_buffremoved"] = " removed, matched "; -- As in ["Greater Blessing of Salvation" removed, matched "Salvation"]
L["TankBuddy"] = "Tank Buddy";
L["Test"] = "Test";
L["EnableAnnounce"] = "Enable announcement"
-- TODO create UI parent, merge titles under
-- TODO update intro/help dext for BCC and BlizzUI
L["IntroText"] =
"Thank you for using Tank Buddy, formerly known as Taunt Buddy.\nTaunt Buddy was originally created by Artun Subasi, but since he stopped development, Kolthor from Doomhammer EU took over. Updated for 2.4 combatlog & Paladin support by Raeldar.\n\nTo the right there are a number of tabs, depending on your class. Each tab has options for announcement message, and channels to announce to under given circumstances."
L["HelpText"] =
"Buff removal:\nTo remove unwanted buffs, there are two options; Always, and only in defensive stance/bear form/Righteous Fury.\nTank Buddy will look for buffs containing any of the text specified. To look for several buffs, just seperate with a comma (,). Note! You don't need to type the entire name of the buff, just portions. Example: \"Intellect, Spirit\" will look for any buffs that has the word \"Intellect\" or \"Spirit\" in it, and remove them. This will match \"Arcane Intellect\" and \"Prayer of Spirit\", but also the Scroll of Intellect and Sprit buffs and any other buff that has \"Intellect\" or \"Spirit\" in it's name.\n\nTabs:\nThe leftmost column of checkboxes controls which channels to send the announcement message to, if you are in a raid. The middle column, if you are in a party, and the rightmost column, if you are alone.\nIf you check any of the \"Custom\"-boxes, a window will appear where you can type in the custom channel(s), either by channel name or number. To specify more than one channel, seperate with a space.\nWhen you have selected some channels, you can click the \"Copy\"-button to copy your selection, and then click another tab, and click the \"Paste\"-button to use the same selection there.\nNote! This will overwrite any custom channels you might have typed, with the ones from the copied source.\nYou can specify a message in the editbox at the bottom, and use the variables listed below.\nIf you select \"Enable announcement for recovery of failed taunts\" in the taunt-tab, you can type a message to announce in the event that you successfully hit with a Mocking Blow, after a failed taunt. Note! This will only work until Taunt is no longer on cooldown, and only if your current target has the same name and level as the one that resisted the taunt.\n\nVariables:\nTaunt, Growl and Mocking Blow:\n$tn: Target Name (Same as %t)\n$tl: Target Level\n$tt: Target Type (Humanoid, Beast, Demon etc.)\n$ttn: Target's Target Name\n$ttl: Target's Target Level\n$ttt: Target's Target Type\n\nShield Wall, Challenging Shout, Challenging Roar, Last Stand and Lifegiving Gem:\n$sec: Duration of ability in seconds\n\nLast Stand and Lifegiving Gem:\n$hp: Amount of hitpoints gained by the ability.";
-- TODO merge into abilities
L["defaultText"] = {
["recovery"] = "- My Mocking Blow RECOVERED my resisted taunt! -"
}
L["Auras"] = {["Salvation"] = "Salvation", ["RF"] = "Righteous Fury"}
L["Abilities"] = {
["CR"] = {
["Name"] = "Challenging Roar",
["Default"] = "- I activated Challenging Roar! I will need a lot of healing for $sec seconds! -",
["Prompt"] = "Enter new announcement text for using challenging roar:"
},
["CS"] = {
["Name"] = "Challenging Shout",
["Default"] = "- I activated Challenging Shout! I will need a lot of healing for $sec seconds! -",
["Prompt"] = "Enter new announcement text for using challenging shout:"
},
["FR"] = {["Name"] = "Fel Rage", ["Default"] = "", ["Prompt"] = ""},
["Growl"] = {
["Name"] = "Growl",
["Default"] = "- My Growl has been resisted by $tn! -",
["Prompt"] = "Enter new announcement text for resisted growls:"
},
["LS"] = {
["Name"] = "Last Stand",
["Default"] = "- I activated Last Stand! In $sec seconds I will lose $hpHP! -",
["Prompt"] = "Enter new announcement text for using last stand:"
},
["MB"] = {
["Name"] = "Mocking Blow",
["Default"] = "- My Mocking Blow failed against $tn! -",
["Prompt"] = "Enter new announcement text for failed mocking blows:"
},
["RD"] = {
["Name"] = "Righteous Defense",
["Default"] = "- My Righteous Defense has been resisted by $tn! -",
["Prompt"] = "Enter new announcement text for resisted Righteous Defense:"
},
["SW"] = {
["Name"] = "Shield Wall",
["Default"] = "- I activated Shield Wall and will be taking 75% less damage for $sec seconds! -",
["Prompt"] = "Enter new announcement text for using shield wall:"
},
["Taunt"] = {
["Name"] = "Taunt",
["Default"] = "- My Taunt has been resisted by $tn! -",
["Prompt"] = "Enter new announcement text for resisted taunts:"
}
}
L["Items"] = {
["Title"] = "Items and buffs",
["Default"] = "Adamantine Shell,20,1280 armor",
["Prompt"] = "Enter one item per line to announce: Buff name,Seconds,Effect",
["Template"] = "- I gained $effect for $sec seconds - "
}
L["RemoveBuffs"] = {
["Title"] = "Buff removal",
["Always"] = "Always remove buffs containing:",
["DRUID"] = "Only in bear form:",
["WARRIOR"] = "Only defensive stance:",
["PALADIN"] = "Only when Righteous Fury is active:"
}
L["Channel"] = {
["Emote"] = "Emote",
["Yell"] = "Yell",
["Party"] = "Party",
["Raid"] = "Raid",
["RaidWarning"] = "Raid Warning"
}
Now i understand what you mean.
But I don't mind the addon interface and announcement texts showing in english.
Is there any way to make this addon work(in english) in KR client?
Is there any way to make this addon work(in english) in KR client?
Not really. The addon needs to know exactly what the ability names are. Because it looks at the buffs that come and go.
At a minimum these need updated to Korean as your client displays it.
L["Auras"] = {["Salvation"] = "Salvation", ["RF"] = "Righteous Fury"}
L["Abilities"] = {
["CR"] = {
["Name"] = "Challenging Roar",
},
["CS"] = {
["Name"] = "Challenging Shout",
},
["FR"] = {["Name"] = "Fel Rage", ["Default"] = "", ["Prompt"] = ""},
["Growl"] = {
["Name"] = "Growl",
},
["LS"] = {
["Name"] = "Last Stand",
},
["MB"] = {
["Name"] = "Mocking Blow",
},
["RD"] = {
["Name"] = "Righteous Defense",
},
["SW"] = {
["Name"] = "Shield Wall",
},
["Taunt"] = {
["Name"] = "Taunt",
}
}
Should be functional in v3.0.12
It still doesn't work in KR client.
Is it the translation problem or other issues?
Is it the translation problem or other issues?
I have no idea, you haven't given me anything to work with.
What doesn't work? What error (BugGrabber/BugSack)? What are you doing and expect to work?
I expect the addon to show a message whenever taunt is resisted, or mocking blow is resisted, and whenever I use Last Stand,
Challenging Shout, Shield Wall playing as a warrior.
Any of the following function doesn't work and below are two lua error messages I got from buggrabber.
--------------------------------------------------------------------------------------------------------
1x [ADDON_ACTION_BLOCKED] 애드온 'TankBuddy'|1이;가; 보호된 함수 'MultiBarBottomLeft:SetShown()' 호출을 시도했습니다.
[string "@!BugGrabber\BugGrabber.lua"]:519: in function <!BugGrabber\BugGrabber.lua:519>
[string "=[C]"]: in function `SetShown'
[string "@FrameXML\MultiActionBars.lua"]:39: in function <FrameXML\MultiActionBars.lua:34>
[string "@FrameXML\MultiActionBars.lua"]:52: in function `MultiActionBar_Update'
[string "@FrameXML\InterfaceOptionsPanels.lua"]:1178: in function `setFunc'
[string "@FrameXML\InterfaceOptionsPanels.lua"]:87: in function <FrameXML\InterfaceOptionsPanels.lua:83>
[string "=[C]"]: in function `pcall'
[string "@FrameXML\InterfaceOptionsFrame.lua"]:216: in function <FrameXML\InterfaceOptionsFrame.lua:215>
[string "=[C]"]: ?
[string "@FrameXML\InterfaceOptionsFrame.lua"]:251: in function <FrameXML\InterfaceOptionsFrame.lua:247>
--------------------------------------------------------------------------------------------------------
1x ...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-81.lua:1867: AceConfigRegistry-3.0-20:ValidateOptionsTable(): TankBuddy.args.buffRemoval.args.removeBuffsDefensive.name: expected a string or funcref, got 'nil'
[string "=[C]"]: ?
[string "@Accountant_Classic\Libs\AceConfig-3.0-3\AceConfigRegistry-3.0\AceConfigRegistry-3.0-20.lua"]:50: in function <...-3.0\AceConfigRegistry-3.0\AceConfigRegistry-3.0.lua:45>
[string "@Accountant_Classic\Libs\AceConfig-3.0-3\AceConfigRegistry-3.0\AceConfigRegistry-3.0-20.lua"]:210: in function <...-3.0\AceConfigRegistry-3.0\AceConfigRegistry-3.0.lua:205>
[string "@Accountant_Classic\Libs\AceConfig-3.0-3\AceConfigRegistry-3.0\AceConfigRegistry-3.0-20.lua"]:244: in function <...-3.0\AceConfigRegistry-3.0\AceConfigRegistry-3.0.lua:219>
[string "@Accountant_Classic\Libs\AceConfig-3.0-3\AceConfigRegistry-3.0\AceConfigRegistry-3.0-20.lua"]:254: in function <...-3.0\AceConfigRegistry-3.0\AceConfigRegistry-3.0.lua:219>
[string "@Accountant_Classic\Libs\AceConfig-3.0-3\AceConfigRegistry-3.0\AceConfigRegistry-3.0-20.lua"]:254: in function <...-3.0\AceConfigRegistry-3.0\AceConfigRegistry-3.0.lua:219>
[string "@Accountant_Classic\Libs\AceConfig-3.0-3\AceConfigRegistry-3.0\AceConfigRegistry-3.0-20.lua"]:282: in function `ValidateOptionsTable'
[string "@Accountant_Classic\Libs\AceConfig-3.0-3\AceConfigRegistry-3.0\AceConfigRegistry-3.0-20.lua"]:324: in function `app'
[string "@Accountant_Classic\Libs\AceConfig-3.0-3\AceConfigDialog-3.0\AceConfigDialog-3.0-81.lua"]:1867: in function `Open'
[string "@Accountant_Classic\Libs\AceConfig-3.0-3\AceConfigDialog-3.0\AceConfigDialog-3.0-81.lua"]:1960: in function <...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:1958>
[string "=[C]"]: ?
[string "@Accountant_Classic\Libs\AceGUI-3.0\AceGUI-3.0-41.lua"]:72: in function <...ns\Accountant_Classic\Libs\AceGUI-3.0\AceGUI-3.0.lua:70>
[string "@Accountant_Classic\Libs\AceGUI-3.0\AceGUI-3.0-41.lua"]:306: in function `Fire'
[string "@Accountant_Classic\Libs\AceGUI-3.0-41\widgets\AceGUIContainer-BlizOptionsGroup.lua"]:20: in function <...GUI-3.0\widgets\AceGUIContainer-BlizOptionsGroup.lua:19>
[string "=[C]"]: in function `Show'
[string "@FrameXML\InterfaceOptionsFrame.lua"]:29: in function `InterfaceOptionsList_DisplayPanel'
[string "@FrameXML\InterfaceOptionsFrame.lua"]:47: in function `InterfaceOptionsListButton_OnClick'
[string "*:OnClick"]:2: in function <[string "*:OnClick"]:1>
``