[CF 1250] DRData out of sync
tmw-issue-import opened this issue ยท 4 comments
Hi,
I maintain an addon called AdiButtonAuras and a user posted an issue today - AdiAddons/AdiButtonAuras#213
We tracked it down to the version of DRData you are using. It appears to contain old data.
The problem boils down to both of us using different versions of DRData and yours having a higher minor than ours. I moved away from the wowace version of DRData since the project is not listed anymore. However it appears that the git repo is still around and you push to it, so now our histories diverge.
The version I maintain could be found under https://github.com/AdiAddons/DRData-1.0 It has been just partially updated for legion but the old spell ids are definitely removed.
I do plan to drop DRData support in the mid-term since it does not detect silences and knockbacks and it is possible for me to provide the spells for the other categories through LibPlayerSpells (I still have to evaluate this though, so not set in stone).
So, the question is how should we solve this? If you would merge my changes I could switch back to the wowace repo. Or you could pull from https://github.com/AdiAddons/DRData-1.0.git if you wish. Just tell me what you prefer.
Posted by CurseForge user rainrider | Imported from CurseForge issue #1250 | Raw
If you're going to fork off of the main version, you need to rename the major version of your fork. TellMeWhen is far from the only addon that uses the official DRData - there at at least 7 others (7 here, including you: http://www.wowace.com/addons/drdata-1-0/reverse-relationships/, and classic Gladius also uses it but isn't listed on that page).
I'm confused when you say it isn't listed. It's right here, and I've updated it with what should be all the changes needed for Legion to the best of my ability: http://www.wowace.com/addons/drdata-1-0/files/
If you're concerned about it being marked abandoned, why not have Adirelle, who is a listed author on it, go poke the project status? That will get it listed back up on Curse.com, if that's what you meant.
Otherwise, you're welcome to keep using the official repo and contribute your changes there - it's open for commits from anyone.
Posted by CurseForge user Cybeloras
Well, it says in a big red box that the project is abandoned. If you search for DRData on wowace or curse, it is not listed in the search results. The only way to know that it exists is to now the exact project link, which I happened not to know :) It is pointless discussing which one is official or not, I'd just want to find a solution.
All the spell ids from the bug report I got are still in v2.8.6-54-g343ae86, which is the most current update and they are all not in the game anymore. The IDs are 1499, 60192 and 119403.
Feel free to use the spell data from the AdiAddons fork, I don't care about credits. The spells for monk, hunter and demon hunter are verified in game. Since there is no official info on DR for Legion, I can't tell for sure that they are in the proper category, I relied on the tooltips.
Posted by CurseForge user rainrider
I pushed the needed changes and switched back to the repo on wowace. This should fix the situation for the time being.
Posted by CurseForge user rainrider