TellMeWhen

TellMeWhen

24M Downloads

[CF 1297] Condition Icon > Condition > Consecration: Incorrect Duration

tmw-issue-import opened this issue ยท 1 comments

commented

What steps will reproduce the problem?
1. Log in on a (Protection/Holy) Paladin with Consecration and a reasonable amount of haste (>10%).
2. Create a condition Icon (use default settings).
3. Add a condition: Consecration.
4. Exit config mode.
5. Cast Consecration.
6. Stay in Consecration until the in-game animation (projected texture) disappears.
7. Observe how the icon is visible longer than your Consecration buff.

ADDITIONAL INFORMATION:
I've investigated this myself: the Blizzard Totem API (GetTotemInfo/PLAYER_TOTEM_UPDATE) does not account for haste. Working hacky fix:
1. Insert the following code after line 509 in TellMeWhen\Components\Core\Conditions\Categories\Spells.lua:
if duration and duration ~= 0 and UnitClass("player") == "Paladin" and name == "Consecration" then
    duration = duration / (1 + GetCombatRatingBonus(CR_HASTE_SPELL) / 100)
end
2. Change the way conditions of this category are updated: make it update OnUpdate instead of on PLAYER_TOTEM_UPDATE event by removing a few lines after line 530 in the same file:
events = function(ConditionObject, c)
    return
        ConditionObject:GenerateNormalEventString("PLAYER_TOTEM_UPDATE")
end,

What version of TellMeWhen are you using? ("The latest" is not a version)
8.1.4


Posted by CurseForge user Zeemlap | Imported from CurseForge issue #1297 | Raw

commented

If this is still a problem, open a new issue. However, I still probably won't do anything about a bug on Blizzard's end.


Posted by CurseForge user Cybeloras