TellMeWhen

TellMeWhen

24M Downloads

[CF 1428] Request for new available state

tmw-issue-import opened this issue ยท 2 comments

commented

Hi there, I absolutely love the AddOn, been using for years. I have a bug bounty I'd be happy to donate $100 for the resolution of. I recently came across a mechanic I needed to represent for which I didn't have the available state.

When a mage casts Flurry, Winter's Chill debuff will be applied to the target. The presence of a debuff is obviously available as state, but it unfortunately doesn't fit this use case. Flurry is a missile spell that takes a few MS to land, before the debuff is applied, and there is a gap in timing that I need to indicate to use Ice Lance.

The availability of Last Used spell is somewhat functional for this use case, as I can check if Last Used is Flurry. There is, however, no timeout on this. So upon the target dying or anything like that, the icon will remain active indefinitely until another ability is used.

There are therefore 3 adjustments that could be made to fit this use case, and IMO all 3 should be added as they are all useful.
1.) A timeout on Last Used (i.e. Last Used within the past 3 seconds)
2.) A spell state of "in flight", which would indicate that a spell was cast but has not landed on the target yet. I assume the game makes the states available to let you know that a spell has been cast, and then you can check for a hit/crit/miss/absorb etc to determine whether it has landed.
3.) A timeout since a buff or a debuff fell off of player/target.

Any of those 3 additions of state would suit my use-case, for which I would consider the bounty fulfilled. The remaining 2 issues are still useful pieces of state that surely others have uses for in their conditionals.

Thank you, and thanks for the great AddOn


Posted by CurseForge user ralusek | Imported from CurseForge issue #1428 | Raw

commented

Obviously I'm not Cybeloras but - 

 

You want a short duration timer that lasts for a <1.5s to denote a window of time where you can shove an ice lance before/while flurry hits (because they both get effected by fingers or something like that?) right?

 

Combat event icon tracking flurry, set to cast success, source player, don't reset since flurry prob hits multiple times and might try to refresh the icon and just put a custom icon for ice lance to remind yourself.

 

^1^T^SShowTimer^B ^SCLEUEvents^T ^SSPELL_CAST_SUCCESS^B ^t^SType^Scleu ^SCLEUDur^N1.5 ^SName^SFlurry ^SCLEUNoRefresh^B ^SSettingsPerView^T ^Sicon^T ^STextLayout^Sicon2 ^t^t^SCustomTex^S30455 ^SStates^T ^N1^T ^t^N3^T ^t^N4^T ^t^t^SEnabled^B ^SSourceUnit^Splayer ^t^N84002^S~`~| ^Sicon^^

 

Should work if I understand you right.

 

E: I'm not sure if when you cast flurry you ALWAYS want to lance right after for this effect, but if it's conditional based on certain buffs being up, you can just add those buffs individually as conditions under buff -> buff duration -> != absent

 

E2: Alternatively, if there's a VERY specific window where you have to cast that ice lance (can't just shove it instantly after the flurry, there has to be some kind of self-imposed delay) then you could make 2 auras, 1 condition aura for last spell cast = flurry and 1 condition aura that watches the first aura and will only show after it has appeared after X seconds. Might still have to tack on buff conditionals to the first one too.


Edited Jul 15, 2017

Posted by CurseForge user Jalopyy

commented

Does this work for you, ralusek?


Posted by CurseForge user Cybeloras