TellMeWhen

TellMeWhen

Addons
24M Downloads

[CF 1529] Load basic info of component icons from different profiles

tmw-issue-import opened this issue ยท 3 comments

commented

(This is basically a reopen of https://wow.curseforge.com/projects/tellmewhen/issues/1442. After that issue was closed, the problem went away for other specs in the same profile, but it still exists cross-profile.)

 

A meta icon may have icons from two different profiles as component icons. This works fine as each icon is only loaded in its respective profile. However, in the dropdown, the component icons from not-currently-loaded profiles appear as "Unknown/Unavailable Icon".

 

  • It is not possible to distinguish between the not-loaded icons, versus truly invalid icons. There could be an invalid component icon in the middle of the screenshot below that I should delete, but I wouldn't know without manually checking every single profile. (I would consider this the main issue.)
  • One has to uncheck "Warn about invalid icons" to avoid errors in chat. This is not ideal.
  • One cannot see the names of the not-loaded icons.


Posted by CurseForge user Arcinde | Imported from CurseForge issue #1529 | Raw

commented

I can't do it for icons across profiles - the performance implications are too significant, for one.

 

I think the better way to go about what you're doing is have a meta icon in each profile that represents the profile-specific contents of this uber-meta icon. Then, include just the one meta icon for each profile, and use the Expand sub-metas option.


Posted by CurseForge user Cybeloras

commented

Thanks, that's a good idea, I might just do that.

 

I don't think it'll be a big performance impact, however. One doesn't have to fully load the icon, just build/maintain a GUID to name table. So we traverse over all icons in all groups in all profiles in TellMeWhenDB once, which is probably ~100-1000 table accesses and would add a fraction of a millisecond to load time.


Posted by CurseForge user Arcinde

commented

You're not wrong, but at this point its just not an effort I'm willing to invest. If this turns out to be something that would be helpful to lots and lots of users, then perhaps, but at this point, you're the only person that has ever brought this up as an issue.  Sorry.


Posted by CurseForge user Cybeloras