TellMeWhen

TellMeWhen

24M Downloads

[CF 1540] Wrong Cold Snap id and Lua Error.

tmw-issue-import opened this issue ยท 1 comments

commented

Greetings. Please fix id of "Cold Snap" in "TellMeWhen\Components\IconTypes\IconType_unitcooldown\unitcooldown.lua" file. Now it's 235219 instead of 11958. And please take a look on this Lua Error. 

1x [string "safecall Dispatcher[1]"]:9: script ran too long
[string "safecall Dispatcher[1]"]:9: in function <[string "safecall Dispatcher[1]"]:5>
(tail call): ?
TellMeWhen\TellMeWhen-8.5.2.lua:2669: in function `UpdateNormally'
TellMeWhen\TellMeWhen-8.5.2.lua:2790: in function `Update'
TellMeWhen\TellMeWhen-8.5.2.lua:2798: in function `?'
...ceDetails\Libs\AceTimer-3.0\AceTimer-3.0-17.lua:55: in function <...ceDetails\Libs\AceTimer-3.0\AceTimer-3.0.lua:50>

Locals:
func = <function> defined @TellMEwhen\Components\Core\Group.lua:424
(*temporary) = true
(*temporary) = "script ran too long"
method = <function> defined @TellMEwhen\Components\Core\Conditions\ConditionObject.lua:259
arg1 = <table> {
conditionString = "local ConditionObject = ...
return (
(bit_bor(bit_lshift(1, (( GetZoneType2() ) or 1) - 1), 4) == 4) -- 1_INSTANCE2
and( TABLES.table_00000267700A0A20[( UnitSpec("arena3") )] ) -- 2_UNITSPEC
)"
NextUpdateTime = inf
UpdateMethod = "OnEvent"
RequestedEvents = <table> {
}
Failed = true
AutoUpdateRequesters = <table> {
}
UpdateFunction = <function> defined ConditionEvents_INSTANCE2_UNITSPEC:0
getsExternallyUpdated = true
registeredForUpdating = true
numArgsForEventString = 1
updateString = "local ConditionObject, event, arg1 = ...
if (not event or
(event == 'PLAYER_TALENT_UPDATE') or
(event == 'ZONE_CHANGED_NEW_AREA') or
(event == 'TMW_UNITSPEC_UPDATE') or
(event == 'PLAYER_DIFFICULTY_CHANGED') or
(event == 'ARENA_OPPONENT_UPDATE')
) then


-- Don't check the condition or request an immediate check if event is nil
-- since event is only nil when manually calling from within :Check()
if not event then return end

-- Check the condition:
if ConditionObject.doesAutoUpdate then
ConditionObject:Check()
else
ConditionObject.UpdateNeeded = true
end
end"
CheckFunction = <function> defined Condition_INSTANCE2_UNITSPEC:0
funcIdentifier = "_INSTANCE2_UNITSPEC"
ExternalUpdaters = <table> {
}
}
xpcall = <function> defined =[C]:-1
call = <function> defined safecall Dispatcher[1]:3
eh = <function> defined @TellMEwhen\TellMeWhen.lua:459

 Sometimes it pops and TMW just stops working (mostly in arenas).


Posted by CurseForge user Fenemore | Imported from CurseForge issue #1540 | Raw

commented

Will fix cold snap. Nothing I can do about that error - it appears Blizzard is placing execution time limits while out of combat for no reason - that's the only way that error could happen.


Posted by CurseForge user Cybeloras