TellMeWhen

TellMeWhen

24M Downloads

[CF 1618] More source/destination condition fuckery

tmw-issue-import opened this issue ยท 11 comments

commented

^1^T^SType^Scleu ^SSourceUnit^Sarena1-3 ^SCLEUDur^N2 ^SName^SLeg~`Sweep;~`Kidney~`Shot;~`Mighty~`Bash;~`Maim;~`Disarm;~`Dismantle ^SGUID^STMW:icon:1RqjhrhizTyW ^SCLEUEvents^T ^SSPELL_CAST_SUCCESS^B ^t^SSettingsPerView^T ^Sicon^T ^STextLayout^STMW:textlayout:1OGdypbfDA7b ^STexts^T ^N1^SImmuned~`[Spell]! ^t^t^t^SCustomTex^Sblank ^SStates^T ^N1^T ^t^N3^T ^t^N4^T ^t^t^SDestUnit^Splayer ^SEnabled^B ^SDestConditions^T ^N1^T ^SType^SBUFFDUR ^SOperator^S~|= ^SName^SBladestorm ^t^Sn^N1 ^t^t^N85506^S~`~| ^Sicon^^

^1 ^T^N1^T ^SName^SPT~`Sans~`Narrow ^SConstrainWidth^b ^SStringName^SNumber ^t^SGUID^STMW:textlayout:1OGdypbfDA7b ^SName^SCenter~`Number~`2 ^t^N85506^S~`~| ^Stextlayout^STMW:textlayout:1OGdypbfDA7b ^^

 

This event should trigger when someone casts one of the tracked spells on me, with the destination filtering it on me so it only procs when I am also bladestorming. But I still this icon when I am not bladestorming, and also when those spells are cast on other people while I am bladestorming.


Posted by CurseForge user Jalopyy | Imported from CurseForge issue #1618 | Raw

commented

I bladestorm within the first 30 seconds of most any arena match so...I'm gonna guess the first one?


Posted by CurseForge user Jalopyy

commented

But is it ever wrong after that first bladestorm? Or does it work after that?


Posted by CurseForge user Cybeloras

commented

Let me add some random shit into the aura and I'll do some skrims to test.


Posted by CurseForge user Jalopyy

commented

I'm fairly positive this aura is only wrong (and also only works) after my first bladestorm. I can't make it proc before a bladestorm

 

I faced a fire mage/arms warr in skrims and added the following to tracked spells.

 

Mortal Strike; Overpower; Slam; Warbreaker; Fireball; Fire Blast; Pyroblast

 

It only proc'd off of Warbreaker, and it appeared both before AND after pressing bladestorm once.


Edited Nov 24, 2018

Posted by CurseForge user Jalopyy

commented

To further update:

 

1) It the aura is broken before and after a bladestorm

2) When I change the tracked spells from specific things to tracking all spells (blank box) it doesn't track all spells, only some.

3) The spells it DOES track seem to only be spells that require no target (whether they do damage or not). For example, vs an ass/fury warr, I saw the following spells proc the aura:

 

Gladiator's Medallion
Recklessness

Whirlwind

Dragon Roar

Enraged Regeneration

Evasion

Cloak of Shadows

Crimson Vial

Fan of Knives

 

Pretty sure that the aura IS probably tracking what I tell it to, but for some reason it any spell that requires no target will bypass the destination filters entirely. Which would explain why I only ever see it proc off of Leg Sweep, and never anything else.


Posted by CurseForge user Jalopyy

commented

Oh, yes, that's true. Any event that happens that doesn't have a destination can't be ran against your destination filters because there's nothing to check.


Posted by CurseForge user Cybeloras

commented

Then its possible this aura has worked properly the whole time since I originally reported it because it kept improperly showing up when during a leg sweep.

 

Or is there an actual bug in here you think you've found anyway you still need my help for?


Posted by CurseForge user Jalopyy

commented

There was one bug that I did fix. Don't need help testing it - it was fairly obvious once I discovered it. It probably wasn't affecting you, but if it was, it would have only been before you cast your very first bladestorm after logging in.

 

I might add an option to the combat event icon type to only process events if the icon's conditions are passing. Then you could put your bladestorm condition on the icon itself instead of as a destination condition.


Posted by CurseForge user Cybeloras

commented

The latter would be nice. 


Posted by CurseForge user Jalopyy

commented

 Closing this because my issue cannot be fixed and you've already pushed an alpha version that fixes the bug you found yourself.


Posted by CurseForge user Jalopyy

commented

Think I figured out the bug. Is this ever triggering incorrectly after the first time you bladestorm? Or is it only wrong before your first bladestorm?


Posted by CurseForge user Cybeloras