TellMeWhen

TellMeWhen

24M Downloads

[Bug] Classic - Combopoint-dependent auras have no/wrong durations

floomdoom opened this issue ยท 13 comments

commented

Just like the issue with Pounce, the same one exist for Kidney Shot.

Timer sweeper or numerals does not display.
Tried with every possible ID for Kidney Shot.
Using the same settings for every other stun and it works just fine. (Sap, Gouge, Cheap Shot)

EDIT: To clarify, it still tracks Kidney Shot for the right duration. It is just the display of the timer sweeps that is not working.

image

commented

Closing as a duplicate of #1718 - the cause here is the same, since they're both variable durations based on combo points.

commented

Turns out I'm a big dummy and they aren't the same thing at all.

commented

This may now be fixed in c99065e - please test and let me know.

commented

This may now be fixed in c99065e - please test and let me know.

scratch the original message

Downloaded the latest classic Branch, Kidney shot is not being tracked at all. Before it would at least be tracked but without a timer sweeper. Will test a bit more, tomorrow if I messed something up.

commented

@floomdoom sorry, lets try that again. Pushed another fix in 6ada100 - try again with the latest alpha.

FYI, you generally shouldn't download the source straight from Github, as it'll lack a number of things that the build process adds. Download the packaged versions from Curseforge (https://www.curseforge.com/wow/addons/tellmewhen/files)

commented

floomdoom, try the addon nugrunning while they work on this, it works perfectly

commented

@floomdoom please show me a screenshot of the icon editor, which will show your current version. It seems very likely that you're using the wrong version, as other people have reported to me that the fix is working fine for them.

commented

Downloaded the classic on curseforge, it is now back to the original problem.
The debuff is being tracked for the right duration, but the timer sweepers are not working. Neither the numeral one or the visual one displays. (But the other debuffs work again; Cheap Shot, Sap and Gouge.)

I will try delete my old TMW and just install it fresh when I get back to see if that solves anything (dont think it should matter? but I can try just because)

EDIT: The problem persist, I noticed that when tracking Rupture (also a combo-point duration debuff) it shows the time sweeper both visually and numeral for a 1CP Rupture, even when using 5CP. And then the rest of the duration is without any timer indication.

Kidney shot is still not showing any visual indications, no matter the amount of CP used.

EDIT2: A BONUS PROBLEM
Gouge debuff tracking is not taking into account the added 1.5 seconds from 3/3 Improved Gouge. It only tracks the original duration of 4 seconds and not the improved duration of 5.5 seconds.

image

image

image

commented

image

(This morning I deleted my TMW and downloaded it from your link so I think I should be on the right version?)

commented

Nope, that's the wrong version. You'll see something like g6ada1003 in the title bar of the icon editor when you get the right one.

commented

Yepp, ok. Updated now, figured the main-file would've been updated, but found the correct version when browsing all files. My bad.

Cheers. Works like a charm now.
Thanks for your work.

commented

Oh. Apparently curseforge hides alpha versions from the main files page for users that aren't signed in or aren't members of the project. That would explain why everyone I send to that page seems to download the wrong version!

Sorry about that. Curseforge doing curseforge things strikes again!

commented

How could one know though!
Maybe it was resolved even earlier then if I kept trying the wrong versions, haha!

Oh well, thanks again! Been using this addon since it came, love it. Thank you!

Guess this can be closed now! ๐Ÿ‘