WoW Version

Retail

TellMeWhen Version

11.0.4

Describe the bug

My image overlay icons have stopped working (i.e., the image that is supposed to replace the base one when the condition is satisfied does not appear).

Example: for my enhance shaman, I have a MSW stack counting icon that tracks stacks of MSW buff and shows MSW pic by default and I have notifications to change the pic if certain things occur (if i get a stormweaver buff, pic changes to heal pic, etc.). Now, the normal MSW buff icon just stays the whole time and other pictures don't appear when they should.

They have always worked historically. Thanks!

Unable to reproduce.

Please do not ignore the issue template that is provided when you create a new issue. The questions and sections within it provide me with essential information to be able to diagnose and resolve your issue. If you do not include this information, there is little I can do to help you.

Please post the export string(s) of the icons, groups, or profiles you're having trouble with.

To get an export string, open the icon editor, and click the button labeled "Import/Export/Backup". Select the "To String" option for the appropriate export type (icon, group, or profile), and then press CTRL+C to copy it to your clipboard.

Additionally, if applicable, add screenshots to help explain your problem. You can paste images directly into GitHub issues, or you can upload files as well.

Thanks. Here's a simple icon I created that shows maelstrom weapon stacks on enhancement shaman. I set a condition to image overlay the lava burst icon over the default maelstrom weapon icon when lava burst is off CD. But it doesn't show the lava burst icon when it's off CD. It still just shows the default maelstrom weapon icon. These sort of image overlay notifications when conditions are satisfied have always worked in the past.

^1^T^SShowTimer^B ^SType^Sbuff ^SIcons^T ^N1^STMW:icon:1Z6SB5C8rC0k ^t^SName^SMaelstrom~`Weapon ^SGUID^STMW:icon:1b0qndP=QGqc ^SEvents^T ^N1^T ^SType^SAnimations ^SOnlyShown^B ^SAnimation^SACTVTNGLOW ^SEvent^SWCSP ^SOnConditionConditions^T ^N1^T ^SType^SBUFFSTACKS ^SOperator^S> ^SName^SMaelstrom~`Weapon ^t^Sn^N1 ^t^t^N2^T ^SFade^b ^SType^SAnimations ^SAlpha^N1 ^SOnlyShown^B ^SImage^Slava ^SPeriod^N15 ^SAnimation^SICONOVERLAYIMG ^SEvent^SWCSP ^SOnConditionConditions^T ^N1^T ^SType^SSPELLCD ^SName^SLava~`Burst ^t^Sn^N1 ^t^t^Sn^N2 ^t^SSettingsPerView^T ^Sicon^T ^STextLayout^STMW:textlayout:1Z9zqgi9jRqi ^STexts^T ^N1^S[Stacks:Hide(0)] ^t^t^t^SEnabled^B ^t^N110401^S~`~| ^Sicon^^

^1 ^T^N1^T ^SShadow^N1 ^SName^S2002~`Bold ^SSize^N16 ^t^SGUID^STMW:textlayout:1Z9zqgi9jRqi ^SName^SCenter~`Number~`Custom~`2 ^t^N110401^S~`~| ^Stextlayout^STMW:textlayout:1Z9zqgi9jRqi ^^

I think I figured out what is going on. If you set a flash duration for the notification icon (e.g., 15 seconds), it's supposed to start immediately when the condition is satisfied and last for the flash period. What seems to be happening is that, once the condition is met, the default icon gets a turn first, lasting for the full flash period of the notification icon, after which the notification icon gets a turn.

So, for example, if I have maelstrom weapon as my default icon and I set lava burst to show for 15 seconds when it is off CD, then historically it would show for 15 seconds as soon as it is ready. Now, once lava burst is ready, the default icon goes first for the next 15 seconds and THEN lava burst shows 15 seconds later.

I think the ordering got mixed up somehow in the TMW logic code so that, once a notification is triggered, the default icon gets a turn first for the full flash period which isn't how it should work (since it defeats the purpose of the notification). This seems to be a global issue with the logic of TMW affecting icon overlay notifications. But it likely isn't very noticeable if you are using the default .4 seconds flash instead of something longer like I use for alot of mine (15+ sec).

If i have this right, can this please get fixed so that the notification icon pops up as soon as the condition is met?

Thanks!

p.s. I love TMW and consider it to be my most indispensable addon (and have for many years). So many thanks for your work in maintaining it!