[REQ] Account for Incoming Aerial Damage
ggrande opened this issue · 2 comments
What is the feature you would like requested?
In TBC, some of the hardest hitting classes are ranged. This means there is an inherent lag-time between the threat on the meter and the already-cast projectiles/spells due to travel time.
It would be very helpful to estimate the threat gain of spells-in-motion (even if it were as simple as taking an average). A similar feature would be DoTs showing their estimate over-time threat gain. It would probably make the most sense to just stack this estimated threat with a lower opacity on the normal threat.
This would be very helpful for decision-making.
Hi thanks for opening this. I think this is a cool idea, but I think this is incredibly hard to get right so that it will be useful.
You have to remember that threat is inherently lagging behind by up to 1 second because that's the rate the threat value is provided by the game. That means while you are casting your last ability might not be accounted for and you also have not seen new threat from the tank.
So what do I do when, lets say, you are casting back-to-back fireballs. Your fireball is done casting and in-flight, but hasn't hit yet, and you are already casting the next one. Now, to be correct, I would have to account for your in-flight fireball and the fireball you are casting. I have to check the combat log for when the in-flight fireball hit or missed and subtract the estimate once the threat api gives me an update with the actual threat it caused. Cast cancelations have to be monitored too. And ideally, you wanna see an estimate of the threat the tank generated since the last update too.
On top of that a complete damage calculation for any spell including offensive values from gear/base stats needs to be implemented as the actual damage done is only available once the spell hit.
This is all doable, especially as an estimate and not with the goal of complete accuracy, but pretty hard to get right and laborious.
Hi there! I really appreciate the response. I am a big fan of your addon, even after just a few weeks using it. I find its much more reliable than all the alternatives I've tried.
The scenario you described is exactly what I was thinking. I think I underestimated the amount of work required to get it to some degree of reliability. In my mind, you'd just take the average threat increase a particular spell or DoT has had previously in the fight, and use that to guestimate the threat-gain of a cast (despite aerial lag-time or, as you mentioned, the 1 second delay).
Though, I would say, it wouldn't have to be completely accurate to be effective. For something like this, I think a 20% margin is more than reasonable -- especially if it weren't added to the entire threat bar but rather as a "projected" threat. I imagine its far more effort than it's worth for what's probably a niche feature.
Thanks again for the work you put into this project!