
Support for Supercharged combo-points (Rogue)
cjgit opened this issue · 8 comments
The war within expansion introduced supercharged combo-points for all rogue specializations:
https://www.wowhead.com/spell=470398/supercharge
Add support for supercharged combo-points
example:
I got it to work on my machine by updating this line here from 'self.UpdateUnitResource = self.UpdateComboPoints' to 'self.UpdateUnitResource = self.UpdateComboPointsRogueWithAnimacharge'
This solution is a workaround just to get things working on my local machine (you probably want a more clean/permanent solution)
I understand what you mean. I will update the Combo Points widget so that it automatically detects if this talent was selected or not. Thanks for reporting this.
I normally don't work with PRs for my own commits, but here it is: #568
So, here's a version that should correctly show supercharged combo points if talent Supercharger is used: https://drive.google.com/file/d/1joQ9-SEnQkCXnDxUBqXe10mG0aFxQ4gU/view?usp=sharing
Feedback is welcome.
I’ll test it. You can also open a pull request and I’ll review the code (if you want).
Thank you.
I tested the following use cases with my subtlety rogue:
- combat with training dummies - no issues found
- combat pvp - no issues found
- combat pve - no issues found
- re-spec abilities - no issues found
- removed ability Supercharger from rogue talent tree - no issue found
- equipped ability Supercharger (rank-1) from rogue talent tree - no issue found
- equipped ability Supercharger (rank-2) from rogue talent tree - no issue found
- applied Supercharger comboPoints are reset when Supercharger ability is removed from talent tree - no issue found
I review the PR >> looks good to me
Thank you for the quick turnaround (the community appreciate the work you put in)
I still need to check it on Classic. Also, currently it does not update the check for Echoing Reprimand when you enter Shadowlands. I also want to add that. But after that, it should be done.
Sounds good. I'll keep testing the version you shared on google driver and let you know if if I find any issues