SoD - Threat system automatic Roles not working for rogue tank
danriduk opened this issue ยท 8 comments
Rogue tank is not working in SoD for threat system for correct colors on other tanks, working on warlock tank.
is looks like the ID for Just a Flesh Wound is incorrect in tidyPlatesCore.lua
line 1882: Addon.PlayerIsTank = IsSpellKnown(400014, false)
listing all the known spells and IDs with
/run for i=1,GetNumSpellTabs()do local _,_,o,n=GetSpellTabInfo(i) for j=1,n do local name=GetSpellBookItemName(o+j,"spell") local _,id=GetSpellBookItemInfo(o+j,"spell") print(name,id) end end
has Just a Flesh Wound ID as 399954 which is just chest rune ability seems like a blizzard side fix to have the correct ID for the rune
I mean I can add this to Addon.IsPlayerTank, but if it's a bug it might show all players with chest rune abilities as tanks, I guess.
yeah it would, not ideal probably needs some way to check if the rune is in spellbook, IsSpellKnown() does not work for passives
This part is only used for Rogue classes, not for other classes, at least. So, are there any other chest runes with which we could test if
IsSpellKnown(400014, false) or IsSpellKnown(399954 , false)
would work of if that would show the Rogue as tank with other chest runes as well.
i believe ID 399954 is just the generic 'chest rune' so it might trigger it if any chest rune is on
Hm, the taunt you get from Just a Flesh Wound is Tease (https://www.wowhead.com/classic/spell=410412/tease), it seems.
Can you check what IsSpellKnown(410412, false) returns with and without the flesh wound rune? Maybe that would work.