TipTacItemRef interfering with Altoholic
zaphon opened this issue · 3 comments
Describe the bug
I re-installed Altoholic this morning as it had broken with the phase 2 pre-patch released last week. Prior to the pre-patch it had been working fine along with TipTac, but after this morning, for whatever reason, if I have TipTac loaded (specifically TipTacItemRef enabled) it doesn't add anything to the tooltips. I've debugged through Altoholic and it's hook is being called and I dumped the tooltip before it returns from it's function (it looks proper when it returns, something is wiping it after this). This function is hooked via TooltipDataProcessor.AddTooltipPostCall.
To Reproduce
Steps to reproduce the behavior:
- Install TipTac
- Install Altoholic
- Configure Altoholic's tooltips to show information (like item counts on alts)
- Mouse over an item, you won't see any counts. However if you go into TipTac's options and disable ItemRefTooltip Modifications it starts working.
Expected behavior
It will be obvious from screenshots
Screenshots
https://imgur.com/a/zA1eFVa - There are 3 screenshots showing the behavior with ItemRefTooltip Modifications disabled, the options screen, and with it enabled.
TipTac Reborn (please complete the following information):
- Version 22.11.18
WoW (please complete the following information):
- Flavor: Retail
- Version 10.0.2.46702
I had the same issue.
I could fix it by using PLAYER_ENTERING_WORLD instead of VARIABLES_LOADED in TipTacItemRef/ttItemRef.lua, lines 254 and 316.
It seems the VARIABLES_LOADED event is too early.
Here the diff:
254c254
< ttif:RegisterEvent("VARIABLES_LOADED");
---
> ttif:RegisterEvent("PLAYER_ENTERING_WORLD");
316c316,317
< function ttif:VARIABLES_LOADED(event)
---
> function ttif:PLAYER_ENTERING_WORLD(event, isLogin, isReload)
> if not isLogin and not isReload then return end– Tom
