TipTac Reborn

TipTac Reborn

1M Downloads

LUA Error When opening the new Pet/Mount/Toy Box Window

Aenimma opened this issue ยท 4 comments

commented

Describe the bug
LUA Error When opening the new Pet/Mount/Toy Box Window

To Reproduce
Steps to reproduce the behavior:
Shift P
The Error pops up

Expected behavior
No error when opening the window

Screenshots
If applicable, add screenshots to help explain your problem.

TipTac Reborn (please complete the following information):

  • Version 23.08.28

WoW (please complete the following information):
Wrath Classic

Additional context

Date: 2023-10-11 15:56:57
ID: 54
Error occured in: Global
Count: 1
Message: Interface/AddOns/TipTac/ttCore.lua line 574:
hooksecurefunc(): SharedPetBattleAbilityTooltip_UpdateSize is not a function
Debug:
[string "=[C]"]: ?
[string "=[C]"]: hooksecurefunc()
[string "@Interface/AddOns/TipTac/ttCore.lua"]:574: hookFnForAddOn()
[string "@Interface/AddOns/TipTac/ttCore.lua"]:1287: fn()
[string "@Interface/AddOns/TipTac/libs/LibFroznFunctions-1.0/LibFroznFunctions-1.0.lua"]:804: CallFunctionDelayed()
[string "@Interface/AddOns/TipTac/ttCore.lua"]:1286: ResolveTipsToModify()
[string "@Interface/AddOns/TipTac/ttCore.lua"]:1187: ApplyConfig()
[string "@Interface/AddOns/TipTac/ttCore.lua"]:839: ?()
[string "@Interface/AddOns/TipTac/ttCore.lua"]:874:
Interface/AddOns/TipTac/ttCore.lua:873
[string "=[C]"]: LoadAddOn()
[string "@Interface_Wrath/FrameXML/UIParent.lua"]:398: UIParentLoadAddOn()
[string "@Interface_Wrath/FrameXML/UIParent.lua"]:534: CollectionsJournal_LoadUI()
[string "@Interface_Wrath/FrameXML/UIParent.lua"]:734: SetCollectionsJournalShown()
[string "@Interface_Wrath/FrameXML/UIParent.lua"]:728: ToggleCollectionsJournal()
[string "TOGGLECOLLECTIONS"]:1:
[string "TOGGLECOLLECTIONS"]:1
Locals:
(*temporary) = defined =[C]:-1

commented

Change lines 574-580 in ttCore.lua to this:

			--hooksecurefunc("SharedPetBattleAbilityTooltip_UpdateSize", function(self)
				-- re-hook OnUpdate for PetJournalPrimaryAbilityTooltip and PetJournalSecondaryAbilityTooltip to anchor tip to mouse position
				if (LibFroznFunctions:ExistsInTable(self, { PetJournalPrimaryAbilityTooltip, PetJournalSecondaryAbilityTooltip })) then
					tt:AnchorTipToMouseOnUpdate(self);
				end
			--end;
		end
commented

@NayooZ that makes a different error pop up on wotlk classic

Date: 2023-10-14 15:17:18
ID: 1
Error occured in: Global
Count: 1
Message: Interface/AddOns/TipTacItemRef/ttItemRef.lua line 2000:
   attempt to index global 'WardrobeCollectionFrame' (a nil value)
Debug:
   [string "@Interface/AddOns/TipTacItemRef/ttItemRef.lua"]:2000: ?()
   [string "@Interface/AddOns/TipTacItemRef/ttItemRef.lua"]:349:
      Interface/AddOns/TipTacItemRef/ttItemRef.lua:349
   [string "=[C]"]: LoadAddOn()
   [string "@Interface_Wrath/FrameXML/UIParent.lua"]:398: UIParentLoadAddOn()
   [string "@Interface_Wrath/FrameXML/UIParent.lua"]:534: CollectionsJournal_LoadUI()
   [string "@Interface_Wrath/FrameXML/UIParent.lua"]:734: SetCollectionsJournalShown()
   [string "@Interface_Wrath/FrameXML/UIParent.lua"]:728: ToggleCollectionsJournal()
   [string "TOGGLECOLLECTIONS"]:1:
      [string "TOGGLECOLLECTIONS"]:1
Locals:
self = TipTacItemRef {
 0 = <userdata>
 ApplyHooksToTips = <function> defined @Interface/AddOns/TipTacItemRef/ttItemRef.lua:1827
 ADDON_LOADED = <function> defined @Interface/AddOns/TipTacItemRef/ttItemRef.lua:1960
 ApplyHooksToCFGDFI = <function> defined @Interface/AddOns/TipTacItemRef/ttItemRef.lua:1928
 SetBackdropBorderColorLocked = <function> defined @Interface/AddOns/TipTacItemRef/ttItemRef.lua:2315
 HookTips = <function> defined @Interface/AddOns/TipTacItemRef/ttItemRef.lua:1955
 SetHyperlink_Hook = <function> defined @Interface/AddOns/TipTacItemRef/ttItemRef.lua:581
 CreateTooltipIcon = <function> defined @Interface/AddOns/TipTacItemRef/ttItemRef.lua:335
 OnApplyConfig = <function> defined @Interface/AddOns/TipTacItemRef/ttItemRef.lua:414
 ApplyHooksToGIFIC = <function> defined @Interface/AddOns/TipTacItemRef/ttItemRef.lua:1942
 ApplyWorkaroundForFirstMouseover = <function> defined @Interface/AddOns/TipTacItemRef/ttItemRef.lua:448
}
event = "ADDON_LOADED"
addOnName = "Blizzard_Collections"
containsBindings = false
(*temporary) = <function> defined =[C]:-1
(*temporary) = nil
(*temporary) = "Fonts\FRIZQT__.TTF"
(*temporary) = <function> defined =[C]:-1
(*temporary) = <table> {
 1 = GameTooltip {
 }
 2 = ShoppingTooltip1 {
 }
 3 = ShoppingTooltip2 {
 }
 4 = ItemRefTooltip {
 }
 5 = ItemRefShoppingTooltip1 {
 }
 6 = ItemRefShoppingTooltip2 {
 }
 7 = EmbeddedItemTooltip {
 }
 8 = NamePlateTooltip {
 }
 9 = false
 10 = false
 11 = false
 12 = false
 13 = false
 14 = false
 15 = false
 16 = false
 17 = false
}
(*temporary) = 17
(*temporary) = nil
(*temporary) = nil
(*temporary) = 17
(*temporary) = 18
(*temporary) = nil
(*temporary) = "attempt to index global 'WardrobeCollectionFrame' (a nil value)"
cfg = <table> {
 nameType = "title"
 colorReactText6 = <table> {
 }
 showRealm = "show"
 classification_elite = "+%s "
 showMount = false
 showMountCollected = false
 showMountText = false
 colorReactText9 = <table> {
 }
 showAuraCooldown = false
 colorSameGuild = <table> {
 }
 showDebuffs = false
 powerBarText = "none"
 healthBarClassColor = false
 t_showTalentText = false
 colorReactText5 = <table> {
 }
 classification_rare = "%s|r (Rare) "
 enableChatHoverTips = true
 colorGuildByReaction = false
 left = 1403.037109
 colorGuild = <table> {
 }
 classification_trivial = "~%s "
 colorReactText10 = <table> {
 }
 top = 24
 gradientTip = false
 colorReactText8 = <table> {
 }
 t_colorTalentTextByClass = false
 showCurrentUnitSpeed = false
 t_showTalentIcon = false
 iconFaction = false
 hideWorldTips = true
 reactIcon = false
 t_showTalents = false
 showTarget = "none"
 t_showAverageItemLevel = false
 tipColor = <table> {
 }
 colorReactText7 = <table> {
 }
 t_colorAILAndGSTextByQuality = false
 classification_normal = "%s "
 enableAnchor = true
 classification_minus = "-%s "
 if_itemQualityBorder = false
 colGuild = "|cff01cc00"
 showBuffs = false
 manaBarText = "none"
 showTargetedBy = false
 t_showGearScore = false
 optionsBottom = 341.962982
 classification_worldboss = "%s|r (Boss) "
 reactText = false
 t_enable = false
 showMountIcon = false
 showTalents = false
 if_iconSize = 51
 colorNameByReaction = true
 classColoredBorder = false
 classification_rareelite = "+%s|r (Rare) "
 healthBarText = "none"
 tipBorderColor = <table> {
 }
 reactColoredText = false
 showMountSpeed = false
 showBattlePetTip = false
 showGuildRank = false
 targetYouText = "<<YOU>>"
 colorNameByClass = false
 anchorWorldTipType = "normal"
 guildRankFormat = "level"
 optionsLeft = 770.395996
}
addOnsLoaded = <table> {
 Blizzard_PetBattleUI = false
 Blizzard_Communities = false
 Blizzard_PerksProgram = false
 Blizzard_EncounterJournal = false
 TipTacItemRef = true
 WorldQuestTracker = false
 Blizzard_AchievementUI = false
 Blizzard_PVPUI = false
 Blizzard_GuildUI = false
 Blizzard_PlayerChoice = false
 Blizzard_Collections = false
}
MOD_NAME = "TipTacItemRef"
LibFroznFunctions = <table> {
 CreatePushArray = <function> defined @Interface/AddOns/TipTac/libs/LibFroznFunctions-1.0/LibFroznFunctions-1.0.lua:647
 MixinDifferingObjects = <function> defined @Inte
AddOns:
  Swatter, v3.4.6977 (SwimmingSeadragon)
  Stubby, v3.4.6920 (SwimmingSeadragon)
  TipTac, v23.08.28
  TipTacItemRef, v23.08.28
  TipTacTalents, v23.08.28
  BlizRuntimeLib v3.4.3.51739(EU) <enUS>
  (ck=c4)
commented

@entroscopy I fixed that as well, have a look at the PR I opened in the link above your post

commented

Thanks for pointing out the parts in the code which causes lua errors with the latest changes in WotLKC patch 3.4.3. ๐Ÿ‘

Fix will be included in the next release.