[Quality Border] For Essences of the Heart of Azeroth
hobulian opened this issue · 7 comments
Not using HoA except timewalking But, It's not quality bordered yet.
I played battle for azeroth for 3 hours at the time. 🙈 So I haven't unlocked anything about the heart of azeroth.
I added a hook to GameTooltip:SetAzeriteEssence() and add some options to "ItemRef":
- added border color and infos for azerite essences
- added mouseover for azerite essences
Is everything working here, or is something still missing?
First time it seemed to working well but have 2 problems.
First is that It worked on AzeriteEssenceUIScrollChild but didn't on AzeriteEssenceUI.~~.UnlockedState(Socket Frame).
https://imgur.com/a/4D3pEKg
Second one is quite serious problem. After clicking chat linked Azerite Essence and popping up ItemRefTooltip For azerite essence, every clicking on default UI(Except ActionBar) such as minimap, chat window, player unit frame or pet's or objective window(quest, etc..) goes broken. You cannot right or left click them, while you can click action bar or bag items or other window's clickable objectives.
I checked that this can happen only with tiptac loaded
I fixed the problem after clicking chatlink of azerite essence. Additionally I added a hook to GameTooltip:SetAzeriteEssenceSlot(). Because I haven't unlocked a slot yet, can you test if it works? 👍
It worked on clicking problem but I think on Azerite Slot quality border problem it's still same.
https://imgur.com/a/Rj4Sxi5
P.S
Found out that
essenceRank(local essenceRank = milestoneInfo.rank;) in
local function SetAzeriteEssenceSlot_Hook(self, slot)
should be
local essenceRank = C_AzeriteEssence.GetEssenceInfo(essenceID).rank;
since milestoneInfo table doesn't have rank info(While it's written on https://wowpedia.fandom.com/wiki/API_C_AzeriteEssence.GetMilestoneInfo but seems it does not rend me rank info when tested)
After changed that it worked.
I fixed the problem after clicking chatlink of azerite essence. Additionally I added a hook to GameTooltip:SetAzeriteEssenceSlot(). Because I haven't unlocked a slot yet, can you test if it works? 👍
Strange, because "milstoneInfo.rank" is used here (a few lines later): https://www.townlong-yak.com/framexml/live/Blizzard_AzeriteEssenceUI/Blizzard_AzeriteEssenceUI.lua#110
But I think this is used here for something else. I added your suggestion to main-branch.