TipTac Reborn

TipTac Reborn

1M Downloads

[Cata 4.4.1] BattlePetTooltip_ShowLink error

Road-block opened this issue ยท 2 comments

commented

Describe the bug

Linking a pet from the Pet Journal causes this error in live Cata 4.4.1 for 2 more days, have not tested if something changed in 4.4.2 (currently on PTR, going live the 18th)

2x TipTac/modules/ttHyperlink.lua:162: attempt to call global 'BattlePetToolTip_ShowLink' (a nil value)
[string "@TipTac/modules/ttHyperlink.lua"]:162: in function `?'
[string "@TipTac/modules/ttHyperlink.lua"]:129: in function `ShowTip'
[string "@TipTac/modules/ttHyperlink.lua"]:71: in function <TipTac/modules/ttHyperlink.lua:70>

Locals:
self = <table> {
}
chatFrame = ChatFrame1 {
 onDisplayRefreshedCallbacks = <table> {
 }
 isLayoutDirty = false
 oldestFadingLineTimestamp = 5467.266000
 tellTimer = 5184.421000
 isDisplayDirty = false
 shouldFadeAfterInactivity = true
 buttonSide = "left"
 checkedGMOTD = true
 textIsCopyable = false
 overrideFadeTimestamp = 0
 fontStringPool = <table> {
 }
 isScrollingMessageFrame = true
 name = "General"
 isUninteractable = false
 mouseOutTime = 0
 minimizeButton = ChatFrame1MinimizeButton {
 }
 buttonFrame = ChatFrame1ButtonFrame {
 }
 isDocked = 1
 alternativeDefaultLanguage = "Common"
 isInitialized = 1
 hasOwnFontObject = true
 allowScroll = true
 oldAlpha = 0
 channelList = <table> {
 }
 FontStringContainer = Frame {
 }
 messageTypeList = <table> {
 }
 flashTimer = 0
 timeVisibleSecs = 120
 fontObject = table: 000001FFBB6D6A20 {
 }
 mouseInTime = 0
 zoneChannelList = <table> {
 }
 insertMode = 2
 hasBeenFaded = true
 defaultLanguage = "Common"
 Background = ChatFrame1Background {
 }
 fadeDurationSecs = 3
 ResizeButton = ChatFrame1ResizeButton {
 }
 visibleLines = <table> {
 }
 scrollOffset = 0
 historyBuffer = <table> {
 }
 clickAnywhereButton = ChatFrame1ClickAnywhereButton {
 }
 isStaticDocked = true
 ScrollToBottomButton = Button {
 }
 editBox = ChatFrame1EditBox {
 }
 isLocked = true
}
refString = "battlepet:279:1:2:100:0:0:BattlePet-0-0000002BE28C:36637"
text = "|cff1eff00|Hbattlepet:279:1:2:100:0:0:BattlePet-0-0000002BE28C:36637|h[Tiny Shale Spider]|h|r"
(*temporary) = nil
(*temporary) = "|cff1eff00|Hbattlepet:279:1:2:100:0:0:BattlePet-0-0000002BE28C:36637|h[Tiny Shale Spider]|h|r"
(*temporary) = "attempt to call global 'BattlePetToolTip_ShowLink' (a nil value)"
showingTooltip = nil
LibFroznFunctions = <table> {
 hasWoWFlavor = <table> {
 }
 TableRegistry = <table> {
 }
 isWoWFlavor = <table> {
 }
}
MOD_NAME = "TipTac"

Steps to Reproduce

No response

Expected behavior

No response

Additional context

No response

Version of TipTac Reborn

25.02.12

Flavor/Version of WoW

4.4.1 Cata Classic

commented

I hopped on 4.4.2 PTR, neither BattlePetToolTip_Show or BattlePetToolTip_ShowLink seem to be part of the client.
They exist in the extracted interface files but they're not part of _G so those files are not loaded for the Cata client.

commented

Thanks for reporting this! ๐Ÿ‘

The functions you mentioned are defined in \Interface\AddOns\Blizzard_FrameXML\BattlePetTooltip.xml and \Interface\AddOns\Blizzard_FrameXML\BattlePetTooltip.lua in TWW interface files, which aren't included in the release of CataC 4.4.1. The tooltip BattlePetTooltip is also missing. The calls to BattlePetToolTip_Show and BattlePetToolTip_ShowLink in the catac interface files seems like dead code. Clicking on the battle pet link also doesn't trigger the standard closeable battle pet tooltip.

I added a check for the existance of function BattlePetToolTip_ShowLink to prevent the mentioned lua error. Fix will be included in the next release.