New Guild Realm addition
Closed this issue · 5 comments
Describe the bug
The newest update that was just pushed has an issue with gathering the realm information for guilds. It appears that even if the Guild is on the same realm as you, it counts it as a foreign realm.
Steps to Reproduce
Steps to Reproduce
- Have the latest version of TipTac installed
- Ensure Show Player Guild Realm setting is set to either 'Show Realm' or 'Show Realm in new line'
- Find a player in which their guild is on the same realm as you
- Mouse over
Expected behavior
No response
Additional context
BugSack Error Catch
67x TipTac/modules/ttStyle.lua:395: attempt to concatenate local 'realm' (a nil value)
[TipTac/modules/ttStyle.lua]:395: in function 'GeneratePlayerLines'
[TipTac/modules/ttStyle.lua]:537: in function 'ModifyUnitTooltip'
[TipTac/modules/ttStyle.lua]:815: in function '?'
[TipTac/libs/LibFroznFunctions-1.0-42/LibFroznFunctions-1.0.lua]:1438: in function 'FireGroupEvent'
[TipTac/ttCore.lua]:3884: in function 'SetUnitAppearanceToTip'
[TipTac/ttCore.lua]:3984: in function '?'
[TipTac/libs/LibFroznFunctions-1.0-42/LibFroznFunctions-1.0.lua]:1438: in function 'FireGroupEvent'
[TipTac/ttCore.lua]:2181: in function 'SetCurrentDisplayParams'
[TipTac/ttCore.lua]:2060: in function <TipTac/ttCore.lua:2059>
[TipTac/libs/LibFroznFunctions-1.0-42/LibFroznFunctions-1.0.lua]:353: in function <...libs/LibFroznFunctions-1.0/LibFroznFunctions-1.0.lua:351>
[tail call]: ?
[C]: in function 'securecallfunction'
[Blizzard_SharedXMLGame/Tooltip/TooltipDataHandler.lua]:61: in function <...lizzard_SharedXMLGame/Tooltip/TooltipDataHandler.lua:56>
[Blizzard_SharedXMLGame/Tooltip/TooltipDataHandler.lua]:81: in function <...lizzard_SharedXMLGame/Tooltip/TooltipDataHandler.lua:77>
[Blizzard_SharedXMLGame/Tooltip/TooltipDataHandler.lua]:117: in function <...lizzard_SharedXMLGame/Tooltip/TooltipDataHandler.lua:107>
[C]: in function 'SetAttribute'
[Blizzard_SharedXMLGame/Tooltip/TooltipDataHandler.lua]:142: in function <...lizzard_SharedXMLGame/Tooltip/TooltipDataHandler.lua:135>
[Blizzard_SharedXMLGame/Tooltip/TooltipDataHandler.lua]:288: in function <...lizzard_SharedXMLGame/Tooltip/TooltipDataHandler.lua:238>
[C]: in function 'securecallfunction'
[Blizzard_SharedXMLGame/Tooltip/TooltipDataHandler.lua]:235: in function 'ProcessInfo'
[Blizzard_GameTooltip/Mainline/GameTooltip.lua]:964: in function 'SetWorldCursor'
[Blizzard_UIParent/Mainline/UIParent.lua]:1355: in function <...rfaceBlizzard_UIParent/Mainline/UIParent.lua:1278>Related Local variables
normalizedRealmName = "Misha"
fullPlayerName = "Volbain-Misha"
guildName = "Naked Raiders"
realm = nilIt appears as though if the target players guild is on the same realm as the user, it doesn't update the guild realm.
This can be temporarily solved via changing the drop down select on the 'Show player Guild Realm' selection to either 'Do not show' or 'Show (*) instead'
Version of TipTac Reborn
20.05.18
Flavor/Version of WoW
Retail 11.1.5
Unfortunately I can't reproduce this error on my side. Can you please post the output of the following chat command:
/run print(GetGuildInfo("player"))
Thanks!
I pushed out a fix including a check that the guild realm is not empty. So, thanks for reporting this issue! 👍
But I'm still curious what the return values are from the chat command above.
First line is "player" (which is me. However I myself am in a foreign realm guild.
Second line is "Mouseover" (which is someone on the same realm as me, in a guild that is from the same realm)