TipTac Reborn

TipTac Reborn

862k Downloads

[Bug] DropDownList styling is overlapped with ELV UI's styling.

hobulian opened this issue ยท 9 comments

commented

https://imgur.com/a/cQxjvjM

I think recently added styling is somehow darker than other tips

"DropDownList1MenuBackdrop",
"DropDownList2MenuBackdrop",
I think they are overlapped with ELV UI's style for them so it's double back grounded.

Hope there be some options for user's preference for these tips maybe.

commented

I fixed this issue. The locking feature to prevent backdrop changes hasn't been applied to the frames. Seems fine now. Do you agree?

commented

Agreed!

commented

Faster than light responses... nice! ๐Ÿ˜Ž๐Ÿ‘

commented

Hmm has problem with this again
https://imgur.com/a/JCvJ6I8
Sometimes tiptac border seems dimmed and sometimes not. Reloading causes this problem. Think it's priority problem between addons.

commented

Hm, can't reproduce it with ElvUI installed, even after multiple /reload ... ๐Ÿค”

commented

Oh.. I think it was not elv.
It was Windtools, Addon using with Elv(https://www.curseforge.com/wow/addons/elvui-windtools) causes problem.
When I use Windtool's skinning shadow function
https://imgur.com/a/XQ8tI7a
It sometimes causes problem.

commented

This is out of TipTacs scope. ElvUI_WindTools creates a new shadow frame at the original frame (frame.shadow) and sets it the following way:

    local shadow = CreateFrame("Frame", nil, frame, "BackdropTemplate")
    shadow:SetFrameStrata(frame:GetFrameStrata())
    shadow:SetFrameLevel(frame:GetFrameLevel() or 1)
    shadow:SetOutside(frame, size, size)
    shadow:SetBackdrop({edgeFile = LSM:Fetch("border", "ElvUI GlowBorder"), edgeSize = size + 1})
    shadow:SetBackdropColor(r, g, b, 0)
    shadow:SetBackdropBorderColor(r, g, b, 0.618)

The frame strata and level is the same, so it's random which frame is in front. In my opinion, the following adjustment in ElvUI_WindTools is needed:

    local shadowFrameLevel = 1
    if frame:GetFrameLevel() then
        shadowFrameLevel = frame:GetFrameLevel() - 1
        if shadowFrameLevel < 0 then
            shadowFrameLevel = 0
        end
    end
    shadow:SetFrameLevel(shadowFrameLevel)
commented

WOW. That was quite a lot of help. Will tell WindTool's author about this. Thanks

commented

np ๐Ÿ˜‰