Total RP 3: Extended

Total RP 3: Extended

903k Downloads

[BfA] Event changes

Solanya opened this issue ยท 1 comments

commented

Just because I thought about it this morning, there are a couple of changes to events in BfA that should be taken into account when updating Extended (I can probably do those updates myself) :

  • Combat log events don't have a payload anymore and rely on calling a function, we should keep a way to access the info in the same way it does right now. There are (as far as I remember) two places to look at : conditions (for condition on event args values) and variable parsing (${event.X} parse as the Xth argument of the event calling a workflow)
  • TRP3_KILL needs to be updated with the changes to combat log events
  • Registering/Unregistering an unknown event will throw a Lua error. Is it possible to catch that so we can warn the player (if the campaign tries to register an unknown event) ourselves ? I think it might happen if the player has entered a wrong event in the game events list.

TBD, might get moved to a separate issue later

  • Now that Blizzard has done API documentation, there should be a way to parse that documentation and provide full in-game event documentation accessible from the events tab.
commented

We can surely wrap the event registration in a pcall() and catch if an error is raised.