TotalAP - Artifact Power Tracker

TotalAP - Artifact Power Tracker

104k Downloads

Fix prevaling taint issues in the new GUI

rdw-software opened this issue ยท 1 comments

commented

Apparently, something is still causing protected functions to be called in combat. Even though there are numerous checks in place, it has not stopped throwing the occasional error - see link on CurseForge.

Needs investigating via taintlog and maybe a separate test to check whether or not any GUI code is called in combat that could potentially alter troublesome Frame properties.

Roadmap:

  • Investigate via taintlog and find the offending parts
  • Add tests to see if ANY Update code is still run in combat
  • Find out whether there is a general problem (GUI controller?) and fix it
  • Remove band aid fixes that should no longer be necessary
commented

Disabled all GUI updates during combat in a679500. This should pretty much fix any issues related to taint, as the addon simply doesn't do any GUI work until it's safe to do so again.

There are some minor issues due to not being able to update StateIcons, but those will be tackled shortly.