
Performance in beta with the new Dominos
boomboo opened this issue · 8 comments
Can you comment out the code in https://github.com/tullamods/Dominos/blob/de9f380e031b6daf9ac175d8aff98de6de095ae3/Dominos/bars/actionButtonMixin.lua#L88
And see what happens?
I comented out the functionality, no significant changes or none at all. (to be clear the issue isn't solved by commenting that section)
I'm not sure why or how but version 4 fixed the issue, I retested with v3 and it was still there but v4 fixes it.
Dominos defers action button creation a bit in beta 4, do you happen to shrink your unused action bars?
Yeah that’ll cause those buttons to never be created by dominos (provided they didn’t exist already) and is likely the cause of your CPU usage reduction
Oh so you mean the reduction is incidental in that whatever caused the increase is still there however with v4 there are less buttons to work on?