Elemental Shaman Refactor + Improvements
Twintop opened this issue ยท 1 comments
The Elemental Shaman implementation was one of the first to be done after Shadow and has largely been left alone. There are a lot of issues with it that could use cleanup, including a bug involving Stormkeeper as a result.
Do some cleanup/refactor of Elemental and the Shaman module overall to bring it more in line with Hunters/Priests/Warriors/Demon Hunters in structure:
- [ ] Multispec support structural changes (even if Enhancement and Restoration aren't planned any time soon)
- Standardize variable names
-
- E.g. "stacks" instead of "stacksRemaining"
- Poll for updates about stack counts and buff times remaining instead of manually tracking them when warranted
-
- E.g. The Anima Power "Depleted Tesla Coil" (https://www.wowhead.com/spell=350248/depleted-tesla-coil) isn't being handled right.
- Legendaries
-
- Echoes of Great Sundering (https://ptr.wowhead.com/spell=336215/echoes-of-great-sundering)
-
-
- Bar Text for time remaining
-
-
-
- Icon
-
- Anima Powers worth considering:
-
- Depleted Tesla Coil (https://www.wowhead.com/spell=350248/depleted-tesla-coil) -- see above
Depleted Tesla Coil issue reported by Husky in Discord.