Twintop's Resource Bar

Twintop's Resource Bar

670k Downloads

Mark of the Crane tracking is inconsistent

Twintop opened this issue ยท 0 comments

commented

Sometimes the status of Mark of the Crane on a target is not reflected accurately in bar text.

Deep dive:

Sometime since this was originally implemented in Shadowlands (10.0?), the combat log events used to determine what targets have Mark of the Crane applied (or re-applied) to them changed slightly (or it has always been a bug in my code...regardless).

Mark of the Crane only has a combatlog event when it is applied (SPELL_AURA_APPLIED) or removed (SPELL_AURA_REMOVED) and not when it is refreshed. The bar keys off of the abilities that apply it (Tiger Palm, Blackout Kick, and Rising Sun Kick) when they are used (SPELL_CAST_SUCCESS).

In 10.0 (I believe) a talent was added, Shadowboxing Treads, which allows Blackout Kick to hit 3 targets in total. When Blackout Kick is used with this talent, SPELL_CAST_SUCCESS is triggered against the target, but SPELL_DAMAGE is triggered against all 3 targets. Since the bar wasn't looking for SPELL_DAMAGE events, these secondary and tertiary targets weren't having their Mark of the Crane data updated.