Since the relase of 10.2.5, there have been multiple reports of excessive (200MB+) memory usage before Garbage Collection takes place on the Shadow part of the Priest module. Other modules (Hunter) haven't shown this.

Confirmed locally with Shadow a few days ago. Quick triaging is pointing to an issue with the now depricated UnitBuff() and UnitDebuff() API calls. Will need to look in to replacing these with newer methods of buff/debuff data update acquisition anyway as they will be removed in 11.0.

I've found a post on the official Blizzard forums that references this issue in a different addon. No follow up, though. https://us.forums.blizzard.com/en/wow/t/unitbuff-usage-in-onupdate-memory-leak-inmy-addon/1770280

Swapped UnitBuff() and UnitDebuff over to use the replacement C_UnitAuras API calls and made a few other adjustments to streamline things. I think we're back close to 10.2.0 levels of memory usage now.

There's more to be done on this with listening to UNIT_AURA (https://warcraft.wiki.gg/wiki/UNIT_AURA) events and capturing auraInstanceID from specific UnitAuraUpdateInfo data.

Work on this will continue in #342