Feature request: play an audio sound when Beast Cleave fades for Beast Mastery Hunter
ghankins opened this issue · 4 comments
Hi, I would like to have TIB play an audio sound when Beast Cleave fades. You don't need one when Beast Cleave is applied because you know that happens with Multi-Shot.
I looked at #427 which seems straight forward but I could not get it to work, even with just enabling the option in the code without adding GUI code.
I cloned the repo but can't commit to send a PR for you to look at.
% git clone [email protected]:Twintop/TwintopInsanityBar.git TwintopInsanityBar-bmbc
% cd TwintopInsanityBar-bmbc/
-- edit stuff
% git branch TwintopInsanityBar-bmbc
% git checkout TwintopInsanityBar-bmbc
% git status
On branch TwintopInsanityBar-bmbc
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: ClassModules/Classes/HunterClasses.lua
modified: ClassModules/Hunter.lua
modified: ClassModules/Options/HunterOptions.lua
modified: Localization/enUS.lua
% git commit -am "First attempt to add sound when BeastCleave fades."
% git push --set-upstream origin TwintopInsanityBar-bmbc
ERROR: Permission to Twintop/TwintopInsanityBar.git denied to ghankins.
fatal: Could not read from remote repository.
I'm OK at LUA but bad at git. If you have time it would be great if you can add this feature, or take a look at what I've hacked for advice on where I went wrong. I appreciate any help you can offer!
Hey @ghankins ! Yes, this shouldn't be too difficult to add. I'll see about getting it done today for a release with 11.1.5.0-release this week.
If you want to make a PR, you'll have to fork the repo branch to your own GitHub profile (e.g. it'd be ghankins/TwintopInsanityBar), make changes, then open a pull request back to the HEAD (Twintop/TwintopInsanityBar).