Twintop's Resource Bar

Twintop's Resource Bar

670k Downloads

Use C_EncodingUtil for Import/Export

Twintop opened this issue ยท 0 comments

commented

Currently, import/export strings are generated via two 3rd party libraries that, for export:

  1. Convert the Lua settings table into JSON
  2. Take the JSON and Base64 Encode it
    (and vice versa to import)

With 11.1.5, Blizzard has added an entire API for handling encoding, serialization, and compression. This is not only far faster than Lua libraries (as these are C functions), but they should be well maintained going forward.

https://warcraft.wiki.gg/wiki/Category:API_namespaces/C_EncodingUtil

Need to compare the output of these built-in methods vs. the current implementation to ensure backward compatibility. If they aren't compatible, we may need to support both for import purposes for a while (through 12.0 maybe?).

Once this works, maybe explore using compression or CBOR instead of JSON.