some potions fail due to item ranks
ScottIngram opened this issue ยท 1 comments
I put an aligari healing potion rank 2 on my UFO but when I clicked it then nothing happened. Didn't drink it. Didn't get a "you're already at full health" message. Nothing.
After testing, I discovered that regardless of what rank potion you click, the Bliz API will only assume rank 1... unless you specify the item ID.
I do not think this problem existed in Dragonflight because I absolutely remember having rank 2 and rank 3 potions work... although I might have had a rank 1 pot in my bag and was always drinking it... except, NO, I had to replenish my rank 2 & 3 pots because I'd use them up. So, yup, thanks Bliz! You broke this between expansions.
my new code fixed it
elseif ButtonType.ITEM == self.type then
-- because using items by name implies rank 1 and never rank 2 or 3 we must use by the item's ID
return ButtonType.ITEM, ButtonType.ITEM, "item:".. self.itemId -- but not just itemId, it must be item:itemId - I hate you Bliz