UFO - Universal FlyOut

UFO - Universal FlyOut

1.3k Downloads

Auto-Close Option breaks flyout buttons

negue opened this issue ยท 16 comments

commented

I don't know for how many versions it is but currently for me the Auto-Close just closes the Flyout

image

Trying to trigger Dreamwalking (dunno if thats the correct name in english, the teleport for druids)

image

commented

Yes, the 'Auto-Close UFO' just closes the flyout. I use the term "UFO" to mean "flyout" and vice versa. Sorry, I should translate the configuration screen. What's your preferred language?

Are you reporting that you can't cast Dreamwalking from a UFO?

commented

UFO = Flyout = Yeah no worries the addon is called like that so thats all good ๐Ÿ˜ฌ

English for most of the stuff, in Game for Quests and such on german so that I can play with my friends ^^

On the topic, I was only mentioning the Dreamwalk as example, I wanted to say that none of the buttons trigger anything when "Auto Close UFO" is active,

tried it with Teleports, mounts and what not, seems the click even is not passed to the button and just closes the UFO

commented

none of the buttons trigger anything when "Auto Close UFO" is active

THANK YOU! A few other users have reported the buttons don't work but you're the first to figure out it's the auto-close that's causing the problem. Excellent, this gives me the clue I needed!

commented

[EDIT] ignore my questions (for the time being). please read my newer comment

@negue may I ask for a little more info to help me recreate this problem please? Can you tell me:

  • a list of what other addons you're using
  • does this happen when the UFO is on any particular action bar? Or does it happen on every bar?

I've been experimenting with various Bliz UI settings and random addons, but I'm failing to recreate this bug :-(

commented

@negue , ok, I've made a guess as to what is causing the problem. If you can, please test it for me?

  • click the "9-auto-close-option-breaks-flyout-buttons" link in the right column near the top of this page
  • on the next page click the "<> Code" menu and select "Download Zip"
  • copy the contents of that zip into your wow/retail/interface/addons dir and replace the existing UFO dir.
commented

Sadly that didn't fix it.

I reloaded it once and also restarted Wow just to be sure.

I disabled all addons but UFO. Tried it on every action bar there is, tried it with a new UFO Group using only the hearthstone still nothing triggers for me.

I'm playing on a German Wow Client, maybe there is something that uses some english only variable?

Other idea, what if the auto close just triggers 2-3 seconds later? Just speculating here, havent read any of the Code yet (also missing a lot of LUA and WoW Addon Knowhow as well haha)

commented

Just had another idea, recently GSE "broke" for me and I think it was because I had this option enable "left click handled as right click" or how its called in english there I had to change the GSE macro to use a different mousebutton instead

Could this be also the issue here?

commented

Sadly that didn't fix it.

Well darn!

I disabled all addons but UFO [and a lot more]

Thanks so much for the time effort!

what if the auto close just triggers 2-3 seconds later

That was my first thought too, but, unless there is some very clever trick that I can't think of, then, Blizzard's secure/restricted environment doesn't provide a delayed function call or even any knowledge of the passage of time.

I'll keep trying.

commented

@negue
Another stab i the dark... maybe this line will do the trick?

file: ui/FlyoutMenu.lua
line #100
SecureHandlerWrapScript(button, "PostClick", button, "return self, 'foo'", CLOSE_ON_CLICK_SCRIPTLET)

commented

Changed the line / reloaded still not reacting on a click

Also just to be sure changed the client to english but also nothing happens

Even tried the oldest version (the oldest release on github) not working.

Maybe we need a debug mode that just spams various console outputs, what if the PostClick event itself not called? (Just throwing in ideas in here :D, no know how yet how WoW Addon System works xD)

commented

still not reacting on a click

Sad Panda!

You're thinking like a developer / coder! I like it :-)

I do have a debug mode built in. For the release code, the debug level is set to WARN (only important stuff is printed) but we can set it to INFO or TRACE and then all kinds of trivial stuff is spammed to the console. If want to experiment, feel free.

Line 17 of UFO.lua is zebug = Zebug:new()

Change it to zebug = Zebug:new(Zebug.OUTPUT.TRACE)

But it will be overwhelming.

what if the PostClick event itself not called?

good question! That code is special protected stuff that can't use my zebug stuff. I'll go in and add some simple print statements where I can. The button that's failing, though, is extra-special protected SecureActionButtonTemplate and isn't even Lua code. It's proprietary, arcane Bliz code that melts my brain. It doesn't support any of my usual debugging methods. I'll research what debug methods it provides, if any.

thanks!

commented

I just checked in a new build that replaces all of the action buttons with macros that simply print the name of the button instead of executing the button.

For me, it looks like:

CLICKED: spell -> Mark of the Wild
CLOSING: UfoGermOn_MultiBarBottomLeftButton12
CLICKED: item -> Eternal Augment Rune
CLOSING: UfoGermOn_MultiBarBottomLeftButton12
CLICKED: toy -> Ethereal Portal
CLOSING: UfoGermOn_MultiBarRightButton1

For you, I suspect I won't have the lines with "CLICKED: ..."

If you can, please install 9-auto-close-option-breaks-flyout-buttons

commented

Sorry to keep asking you to do all of this for me, by the way. I really appreciate your efforts and feedback.

My problem is that I can't reproduce the error, but I completely believe that it's happening to you. So, I've thought up a few experiments to give me more info on how the error might come to be. I'm trying those now...

commented

Ok, I think the latest build (9-auto-close-option-breaks-flyout-buttons) may fix the problem. Fingers crossed!!!

commented

Wonderful news! This is honestly a huge relief. Thank you so very much for all the help!

I'll merge the fix into the trunk and push it over to CurseForge soon.

commented

Sorry for the long response pause

You're thinking like a developer / coder! I like it :-)

I'm one as well ๐Ÿ˜ฌ , just don't know anything about how the addons work / built internally haha

as for the latest build - IT WORKS!!!!!oneoneoneeleven

splitting that on mouse down and up seems to be the solution ๐ŸŽ‰