Vendorer

Vendorer

26.7k Downloads

MAX and STACK Buttons doesn't work.

Galthariel opened this issue ยท 16 comments

commented

Expected Behavior

That at Vendor all 4 Buttons options work (MAX, STACK, OK and CANCEL).

Actual Behavior

At Vendor only the two bottom buttons work (OK and CANCEL)

Steps to Reproduce the Problem

  1. Go to any Vendor which includes the Yak Mount and try to buy a Stack of anything

Tried everything I could think of. Disabled all addons literally and left !Vendorer alone enabled and the issue persists. Deleted the !Vendorer.lua in my Saved Variables (also the bak file) and the issue remains. Deleted the whole Vendorer folder and replace it with the one in here and didn't work also.

Thanks

commented

I can confirm that with my Vendorer install the buttons are properly working.

You can try fully backup-ing your WTF folder, removing it, and letting your settings re-initialize, checking if you can click the buttons.
Secondly, try hovering over the Max button, for example to check if it shows the maximum stack size it can get.
image

Thirdly, try adding a few debug prints, ex. VendorerStackSplitFrame L422,L424,L426 print("set max ", self.split);, to test if the function to set a max size is fired.

Fourthly, what locale do you use?

commented

1st - Did a full backup of my WTF Folder, and only copied Vendorer as an addon. Same issue
2nd - When I mouse over both, MAX and STACK they do highlight, and the tooltip shows I can buy only 0?. (seen screenshot below)
3rd - I couldn't get that command to work in Chat or most likely I don't know what should I do to use the debug print
4th - US Locale
2022-11-11_22-11-05

commented

There you go

2022-11-12_09-58-10

commented

yes, I do have combined bags and use Bagnon. Just remember that I tried with any addons loaded (only Vendorer) and as well with UI reset after backup my WTF folder.

commented

Yeah, this is weird, something is not being initialized well.
VendorerStackSplitFrame.lua
L539-540
self.canFitStacks = Addon:GetFreeBagSlotsForItem(itemLink);
self.canFitItems = self.canFitStacks * maxStack;

That variable might return 0 for you for a reason. Might be a change in Blizzard's API with bags, something to test. Do you have combine bags or using any bag addon?

commented

But have you tried un-combining bags and reloading?

commented

I have not...will try that and let you know. AT work so it will be only later.

commented

Hmm, I was unable to duplicate the issue by playing with Combined Bags on/off, but I was able to find a quirk with how bag slots are counted.
It appears that it's ignoring any extra bag I have, except for the base backpack.
image
Eg. 28 slots, but only 200x20 shown in vendor.
image

Found a function that was changed.

VendorerStackSplitFrame.lua
L633 local bagItemLink = GetInventoryItemLink("player", 19 + bagID);
https://wowpedia.fandom.com/wiki/InventorySlotId -> it is now ContainerIDToInventoryID()

image

commented

TY...will test later. As a side note I have the 4 extra bags from the Authenticator. Don't know if could be the issue

commented

I also do, should not be a problem as Blizzard returns 16 or 20.

commented

They're the same :)

commented

Ok. Thanks for all the help :-)

commented

Fixed :-)

2022-11-14_18-52-35

2022-11-14_18-54-31

Thanks much. I knew wasn't me :-)

commented

Awesome :)

commented

Should I keep using the one you sent me or download any other you may have with consolidated fixes?