VoiceOver (Classic)

VoiceOver (Classic)

923k Downloads

static vmangos release url

DawidMichniuk opened this issue ยท 6 comments

commented

Hi, in tts_cli/init_db.py, your VMANGOS_DB_DUMP_URL points to a fixed file name - this is now broken as Vmangos just updated.

Instead of doing that, try using "https://api.github.com/repos/vmangos/core/zipball/db_latest" - this should point to the latest release every time and proc a zip download!

I'd make this change myself and create a pull request but seems you disabled branching the repo?

commented

Are you unable to fork the repo?

commented

My bad, I'm too used to working with branches - made a PR now!

commented

Your pr doesnt pull the most recent db dump. I think it pulls the source. I've manually updated the static URL for now, but we need to find a long term solution for pulling the db dump.

commented

Found a fix now that gets the latest version and then downloads the correct DB dump zip!

commented

Awesome, thanks! I merged in it. I think we should follow up by checking the name of the file to see if it contains db in it, just in case there is more than 1 download in the future at that link.

commented

Make sure that when the vmangos repo changes (adds more files, changes the naming) - we have some catch in place to stop the script from crashing.

Idea: Check downloaded file if it follows expected format, ask user to download the correct file if something goes wrong - "press enter to continue"