
Splits only visible on same key level
SidneyGuenther opened this issue ยท 1 comments
Hi,
I just switched back from using the M+ Timer WA when I discovered that you support Splits now.
But (at least on my end) the splits are only visible at the same key level. Is this intentional?
I would like to see the splits from the previously highest key timed.
E.g. I timed a +14, now I'm running a +15, here I would like to see the splits from the timed +14 key.
I'm coding a little myself and would like to try implementing this on my own. It just would be amazing to get a few hints on where to start.
Best regards
Sidney
Hi! Thanks for reaching out ๐
Yeah, this is by design currently. I think having an option to also show lower key levels would be a great addition!
It's been a while since I wrote that code, but as far as I remember we basically save best
(the best time) , current
(the time completion time in the current run) and currentDiff
how much faster/slower we were from the best time) for each key level. The diff is saved specifically since we might overwrite the best time at some point, so we just save it in advance to display it while we're still in the same run.
I think you could start by looking at Splits.lua
around line 30, and try to retrieve the best times for lower key levels when none are found.
Some thoughts:
- Maybe it would be good if we show somewhere what key level the diffs are to?
- At the start of the run, we show the best times for a bit. We could have the same behavior there.
- It should definitely be an option whether to show lower levels or not, and how many key levels below should be shown.
- Is displaying higher key levels preferable if they exist? It's probably better as an upper bound, since most casual players won't beat their own times on higher keylevels.
You can also send me a message on the discord server, it might be easier to chat there ๐