WarpDeplete

WarpDeplete

432k Downloads

Properly show force % above 100%

Aeon234 opened this issue ยท 7 comments

commented

Currently the Show forces percent above 100% feature seems to track the percentage of the current pull and while the pull is active shows something like 101.23%.

Once the count hits 100% though, the percent becomes static at 100% and doesn't show at what exact % and number count you're at or finished the dungeon with. I think it's quite beneficial when it tells you how OVER count you are, regardless of us being at 100% or not.

commented

Currently trying to get this done since you've been busy. Not too comfortable with LUA/WoW addons personally so trying to figure out your code.

If you know off the top of the head what needs to be changed lmk

commented

Yeah this is pretty straightforward, I'll give you a quick rundown later today

commented

Alright, I'm pretty sure that the only places where the count value is "truncated" is in Display.lua. There's a few places that clamp the percent to 1.0, you can remove those checks but you have to make sure to still clamp the values used to set the bar progress.

The count value itself should also be clamped in the display methods, so displaying that directly should also be straightforward.

I think it would be good to add an option for displaying percentages/counts over 100%, but I'd be fine with setting the default to showing it.

Just add me on the PR whenever you open it, and I'll have a look and give some pointers ๐Ÿ™‚

commented

Yeah, that's the problem with this addon, debugging it correctly takes quite a while ๐Ÿ˜… I'll have a look as soon as possible, thank you for the PR!

commented

After 5 days of grueling running +2s to test/debug me and my buddy think we've got it properly working now. Tested it both clamped and unclamped and the behavior works as intended. Didn't really seem to be tied solely on Display.lua since a lot of it was being calculated in Events.lua

#65

commented

Solved in #65

commented

Yeah, this shouldn't be too hard. Iirc I capped the percentage to make sure that the bars never overflow, but of course it's possible to only cap the percentage when setting the bar values.

I'm happy to accept contributions, otherwise it could take a week or 2 for me to get to this.