WarpDeplete

WarpDeplete

432k Downloads

3.0.4 moving objective tracker over mini map on login or reload

aruberto opened this issue ยท 8 comments

commented

Using the Modern preset layout
image

When WarpDelete 3.0.4 is installed, upon logging in or re-loading, my objective tracker overlaps my map
image

Downgrading back to 3.0.3 fixes the issue and objective tracker renders correctly underneath mini map
image

commented

ah yeah, didn't really count on the ShowBlizzardObjectiveTracker code running before the HideBlizzardObjectiveTracker ๐Ÿ™‚
but I have a simple enough fix in mind (I can't reproduce the problem though, so if @aruberto can test it, that'd be good)
will send a PR in a sec

commented

I think I know what causes this. If I provide you with a branch with a potential fix, would you be able to test it?

commented

Also, @Numynum could you have a look at this? I suspect the reparenting to UIParent causes this, or maybe we need to also store and restore the position when un-hiding the tracker frame.

commented

FWIW, positioning should generally be unaffected, presumably it's only on initial loading, when the quest tracker position is loaded from edit mode or an addon, where it sets the position relative to the parent
but once the position is set, changing parents has no impact
so as long as we don't mess with the parent until actually hiding the frame, all should be well

TL;DR,I don't see any point storing and restoring the position ๐Ÿ™‚

commented

Ok, gotcha on the positioning bit. Still don't understand how the Show code could run first, but let's see if this fixes it. @aruberto, can you test the branch from the PR? It's a pretty small patch, so you could even just copy the patch into your installation.

commented

WarpDeplete:OnEnable() calls WarpDeplete:Hide() which calls WarpDeplete:ShowBlizzardObjectiveTracker() during the initial loading screen

commented

Applying the change from commit Numynum@7359599 seems to work

commented

Fixed in #81, 3.0.5 includes this.