The addon is not hiding blizzard timer v3.0.5
antedap opened this issue · 14 comments
Hello, the addon is still not hiding blizzard timer inside any dungeon. But I'm not getting any error, I can only take a screenshot if you want
Which version of the addon are you on? This problem should be fixed going forward from v3.0.3. If you are on a newer version than that, could you try v3.0.3 specifically?
Same problem here, it was resolved a few days ago, the blizzard UI no longer hide, I will download version v3.0.3, as reported above and test
Same problem here, it was resolved a few days ago, the blizzard UI no longer hide, I will download version v3.0.3, as reported above and test
So am I understanding correctly that you had the bug on v3.0.5?
For context, we first implemented a very dirty fix in v3.0.3, and then found a better solution in v3.0.4. I'm trying to find out whether the new, better solution causes the issue, or if you were on 3.0.2 or earlier and had the issue because of that.
Same problem here, it was resolved a few days ago, the blizzard UI no longer hide, I will download version v3.0.3, as reported above and test
So am I understanding correctly that you had the bug on v3.0.5?
For context, we first implemented a very dirty fix in v3.0.3, and then found a better solution in v3.0.4. I'm trying to find out whether the new, better solution causes the issue, or if you were on 3.0.2 or earlier and had the issue because of that.
it was on version v3.0.4, and it was ok too, the problem started after the last update, there is an aura called M+ timer, it works perfectly well hiding the UI, I think it would be interesting to look at the method he uses for this.
I have noticed the problem (even after the 3.0.5 update) and written an external hack to fix it. I don't know if this is something you want to use, but here's how I hide and show the objective tracker when WarpDeplete is loaded:
E is my event handler:
E:RegisterEvent("CHALLENGE_MODE_START", function()
ObjectiveTrackerFrame:SetAlpha(0)
end)
E:RegisterEvent("CHALLENGE_MODE_COMPLETED", function()
ObjectiveTrackerFrame:SetAlpha(1)
end)
By making it invisible, it circumvents the problems caused by Blizzard's code.
Hope this is useful.
it was on version v3.0.4, and it was ok too, the problem started after the last update, there is an aura called M+ timer, it works perfectly well hiding the UI, I think it would be interesting to look at the method he uses for this.
I understand, so it's probably the "better" fix we merged in v3.0.5 that reintroduced the problem. In v3.0.4, we actually used the same method as Reloe's M+ timer, which to my knowledge is (or at least was at the time when I looked) just continuously re-hiding the frame.
It's still weird to me that the newest fix seems to work for some people, but not for everyone. I hate the idea of just setting the opacity since the frame will still be there, but I suppose it's an adequate hack to make the problem go away until there's a better solution or blizzard fixes everything they broke on the new patch 😞
I've added a beta release (v3.0.6-beta.1) that also sets the opacity to 0 as per @Dreamlogic22 's code snippet. You can either use the main branch here or use the beta from curseforge. I'd be greatful if any of you could test this and see if it helps!
Can confirm 3.0.5 does not hide the blizzard timer.
Can you also try the v3.0.6 beta and see if there are any issues with it?
I've released the fix as 3.0.6 now, please reopen if there are any further issues.
@happenslol I suppose it could happen if another addon tries to change the parent or something funky like that 🤔
would be interesting to know what addon would be breaking that
@happenslol I suppose it could happen if another addon tries to change the parent or something funky like that 🤔
would be interesting to know what addon would be breaking that
Yeah, I'm pretty sure at this point that it has to be an interaction with other addons, since it definitely works for the larger part of the userbase. I suppose there's nothing we can do about it either way.