[Feature Request] Add best time (or difference between best and current) for bosses and 100% trash count
SingleWeb opened this issue ยท 7 comments
Hello hello!
Awesome addon, simple and friendly UI. But I miss very helpful feature for me - time of the best kill for the boss for the same key level.
I guess it will be very useful for keys greater than +12 for TWW since blizzard fixed affixes after +12 key. I know high pushers can feel timer very well but it will be helpful for other semihardcore pushers if I can see in mm:ss difference (e.g. green/red) between last timed key and the current key of the same level.
This feature could help to understand that the key is already depleted or not or maybe you just need to risk for big pull to catch up the timer.
Thank you for your work, you do amazing addon!
Thanks for the request, and the kind words!
This is a feature that was requested a few times, and even partly implemented before real life got the better of me. It seems like now, a lot of that information can be gotten from the raider.io addon, so that will probably be the path I'm taking instead of doing everything myself and keeping a database.
I'm not 100% sure how active I'm going to be in the new season, but if I'm playing actively again I can say for sure that I'll be implementing this, since it shouldn't be too much work by using the existing raider.io database.
@happenslol Have you had time to start working on this feature yet? I would like to start working on this.
@happenslol Have you had time to start working on this feature yet? I would like to start working on this.
Nope, however it was on my todo-list for this weekend since I'm finally back to playing actively again. I'm happy about any help, of course, so you're welcome to work on this.
There's still some code from the previous "attempt" left over, I'm not sure if it makes sense to try and adapt it or just remove it all and start over. Generally, the feature should work like this:
- When a run starts:
- Get an ID/name for the dungeon, whether the key is tyrannical/fortified and the key level, these will be used to index into the database later
- Clear any previously saved temporary times
- When a boss is killed or count reaches 100%, store the time temporarily in the db (it's important to store it and not just keep it in memory, since we might reload the UI or quit and re-enter the dungeon)
- If there's a stored time for (dungeon,affix,level) already, show the difference beside the kill timestamp
- When the run is completed (timed or not), write the temporarily stored times to the permanent database using the indexes. We shouldn't delete the temporary times yet, it's fine to keep them until the next run starts so we can re-calculate the differences on UI reload after the dungeon is complete.
Some important notes:
- Times should only be saved when a run is completed, anything else doesn't really make sense
- I'm not sure if it makes more sense to have nested objects or just calculate string keys from the (dungeon,affix,level) triple, whichever is more convenient I suppose
- It should be possible to turn off display for the feature, but I don't think recording should be turned off even if you don't want to display it
- There should be a button in the options screen to wipe previous times
Edit: The above is if you want to implement the feature yourself - using the RaiderIO data would be fine too, since it's less code for us to maintain. We'd have to keep up with their API so, so it's a tradeoff. We can have a chat about this on Discord or any other channel you prefer.
@su-wright so, do you want to work on this? Otherwise I'll get on it.
@happenslol I see that the implementation is already almost done but has some bugs/ outdated features. Since it was so close to completion, I was going to let you work on it over last weekend. If you didn't get time, I'm still wanting to give it a shot. My discord is .durty
Doing it on our own should be pretty simple to do. I've only glanced over the documentation, so I'm not too familiar with the raider.io api. I'm not sure if it will give us any extra benefits over doing it in our own DB.
I'm pretty busy right now, so I'd be happy about you helping with this! I've added you on discord.