End-of dungeon timer and upgrade level does not match with Blizzard UI
AserCSGO opened this issue · 19 comments
With the recent changes on the timer that adds 1:30, when you have the affix "Challenger's Peril". The timer doesn't count the extra 1:30 added. Then when you +2 a key sometimes you will see that you didn't on the timer.
I don't have example but this happend to me few days ago and today. I'm of course on the latest version
The rewrite has been completed and released as 4.0. I'll close this for now since the timer code has been changed around a lot, but feel free to reopen if the issue still exists!
Hi, thanks for the report. A big refactor of the core timer functionality (as well as new features like splits, global scaling, and a few other things) is in the works, which fixes this. Would you be interested in beta testing the new release? It's at the point where I would give it to other people for testing, but not quite ready for release.
Hello, I'm not really interesting for beta testing sorry. But keep up the great work, I very like your addon !
Hi, thanks for the report. A big refactor of the core timer functionality (as well as new features like splits, global scaling, and a few other things) is in the works, which fixes this. Would you be interested in beta testing the new release? It's at the point where I would give it to other people for testing, but not quite ready for release.
I did a run now and still bugged It says +2 on the addon's timer but ingame its a +3
It does not look like you're on the latest version - can you make sure you're on at least 4.0?
Can you try 4.0.1? I'm confused since we just display information from the blizzard API as-is at the end of the key (as of 4.0), so there shouldn't be any discrepancies between what we display vs what the blizzard API displays. Will investigate further.
Okay interesting, you're also getting another bug (the objectives saying " defeated" instead of just the boss names) which I haven't seen before. I think some logs would be very valuable here.
I suspect that blizzard changed something with regards to +2 being 80% and +3 being 60% of the time limit, which is why the bars don't match up even though the time reported is completely correct.
I'll create a new release with logging added around this issue specifically for you. Would you be ok with running some of your keys with that release and relaying the logs back to me?
Just looked through the comments on the M+ Timer WeakAura and through some other sites, and it seems like this is an issue that most addons have right now (even raider.io seems to calculate this incorrectly at the moment). Apparently the peril time is not calculated into the end time for +3 chests or something weird. I don't have the capacity to do extensive testing on this at the moment, but as soon as someone figures out the correct math here I'll adapt that.
Ok, its not a big problem but I just wanted to report it anyway. Hope you will find a fix rapidly.
Hi!
Sorry to intrude. I'm the author of the ‘iP mythic timer’ addon and I had a similar report. Last week I fixed the cutoffs for +2 and +3. If interested, in this comment I described how to now correctly calculate timers for +2 and +3 with the "Challenger's Peril" affix.
Hope this helps ;)
ipzaur/ipmythictimer#17 (comment)
@ipzaur Thanks a lot for that! I've been reading through the comments on Reloe's M+ Timer WeakAura, and they curreently have the calculation as ((timer - 90) * 0.8) + 90, I'll have to check which is correct.
Edit: Actually, just looked at it again, and it's the same calculation you're doing, I just misread it. Thanks again!
@ipzaur Ok, after testing and looking at other timers again, it seems like I was right at first. The calculation should be the following:
local timeLimit = ... -- Original time limit
local timeLimitWithoutPerilBonus = timeLimit - 90
local plus2TimeLimit = (timeLimitWithoutPerilBonus * 0.8) + 90
local plus3TimeLimit = (timeLimitWithoutPerilBonus * 0.6) + 90@happenslol
Yes, that's correct. And that is exactly what was described in both my comment and the "M+ WA" comment :)
"Basic dungeon timer" (without 90 sec. of Peril) * "Cutoff coefficient" (0.6 or 0.8) + 90 sec.