WeakAuras

WeakAuras

206M Downloads

Classic

Stanzilla opened this issue ยท 4 comments

commented

So Classic Beta will be released very soon and we need to start talking about how and if we want to handle it. It is currently based on some 8.x client and will be missing API that we added later. This will continue to be the case, see

[18:49:19] Stanzilla_: TSquare: do you know if there are plans to keep api parity between classic and retail?
[18:50:31] TSquare: Where it makes "sense"
[18:50:55] TSquare: For instance: I don't believe the action bar is changing
[18:51:19] TSquare: but to answer your question directly: there is no drive to keep the two in sync
[18:52:24] TSquare: ie: each game can (and will) patch on their own pace.
[18:53:03] TSquare: divergence has, and will probably continue to happen
[19:43:43] Stanzilla_: = (
[19:45:25] Stanzilla_: TSquare: but classic will catch up to changes made to retail eventually, right?
[19:45:28] Stanzilla_: just at a slower pace

(will edit in when he answers)

Now, what are we willing to do? This is an open discussion, there are multiple ways:

  • I think the easiest would be to just add fallback API if we use newer ones not available to Classic
  • or just ignore Classic completely and let the fan forks handle it. I do think Classic might be quite successful, at least for a while so it might be worth looking into it.
  • Create a fork of our own and maintain it (ugh)
commented

That depends on how many differences there are, and whether anyone is interested in maintaining WA for Classic.

I'm not too interested in classic, but suspect that the apis aren't that damatically different, so it might be possible to just check in the places where it matters.

commented

Well like I said, currently a 8.x client, so we'd have to at least add back LibBabbleRace and shim the new APIs that came since then

commented

It's not necessary. The CreatureInfo functions have been added in 8.0.1.27101 (Release build dated 2018-07-16).
https://www.townlong-yak.com/framexml/27101
https://www.townlong-yak.com/framexml/27101/Blizzard_APIDocumentation/CreatureInfoDocumentation.lua

Just use another function to get the class color (for example: GetClassColor or GetClassColorObj)
https://www.townlong-yak.com/framexml/27101/Util.lua#673

commented

@mrbuds forgot to mention that he is working on a classic port: #1347