WeakAuras

WeakAuras

206M Downloads

Stagger Scale does not sanitize input.

nullKomplex opened this issue ยท 0 comments

commented

Describe the bug
Inputting a value that is not a number into Stagger Scale causes an error. This error can prevent options from loading.

Do you have an error log of what happened?

WeakAuras\Prototypes.lua:1582: in function `durationFunc'
WeakAuras\GenericTrigger.lua:2942: in function <WeakAuras\GenericTrigger.lua:2933>
(tail call): ?
WeakAuras\WeakAuras-2.12.4.2.lua:4107: in function <WeakAuras\WeakAuras.lua:4075>
(tail call): ?
WeakAuras\WeakAuras-2.12.4.2.lua:3426: in function `SetRegion'
WeakAuras\WeakAuras-2.12.4.2.lua:3329: in function <WeakAuras\WeakAuras.lua:3265>
WeakAuras\WeakAuras-2.12.4.2.lua:3348: in function `Add'
WeakAurasOptions\WeakAurasOptions-2.12.4.2.lua:540: in function <WeakAurasOptions\WeakAurasOptions.lua:538>
[C]: ?
...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-69.lua:50: in function <...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:48>
...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-69.lua:789: in function <...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:610>
[C]: ?
TomTom\libs\AceGUI-3.0\AceGUI-3.0-36.lua:71: in function <TomTom\libs\AceGUI-3.0\AceGUI-3.0.lua:69>
TomTom\libs\AceGUI-3.0\AceGUI-3.0-36.lua:285: in function `Fire'
...Tom\libs\AceGUI-3.0-36\widgets\AceGUIWidget-EditBox.lua:74: in function <...Tom\libs\AceGUI-3.0\widgets\AceGUIWidget-EditBox.lua:71>

To Reproduce

I have included an aura below, but I recommend following the STR as it's still recoverable (importing breaks entire WA Options)

  1. Create a new aura of any type.
  2. Under Trigger select Status -> Power.
  3. Enable Power Type and select Stagger.
  4. Enable Stagger Scale and input a non-number value.
  5. Observe error. Click any other aura and back to this aura and observe as no options show up. Reload to observe entire WA Options broken (fixing this requires editing Saved Variables).

Screenshots

https://cdn.discordapp.com/attachments/218084462523711489/592085413636866096/unknown.png

Did you try having WeakAuras as the only enabled addon and everything else (especially something like ElvUI) disabled?

Tested with only the 5 official WA addons enabled.

Which version of WeakAuras are you using?

2.12.4.2

Was it working in a previous version? If yes, which was the last good one?

Additional context

Reported by jinxD#3088 on Discord.

!nsvxVTTom0Fn7Xfu7LnS(y(W52aK6KfPEXUVOwzBfhHAl5jjNVEO)2hPK9sAxaUbiWrMMI8Wd5HSigLrQzKc8hCSSsVFHujSS0VZioXbx8kTu5yKjjP0K1bBrZ0khrEsWsJIzKCDL2a3onY)l2)8l(NdXNWTpUCZgRWXsVJr4Q8TAZvcBmgwgzMrE6Tx(rlVWWD83EHsXuORk07vK9YgbBmgezn3j1ke1wh34WdfTgVXNDhb3iwrUwvyHO7FvPvcem1CP629EJujTBVz)HBK3AD6Akurp1uWDW3A7(VVmskkfSmOkYX4zVSgUmJWz4yWkCU1kW(ZepDd3wc5h5cFljrXZQef47VkenJSnIC3AeVORwr1MpY4gzzPWydno6FmGhv8AHnaGUA1XDT2ZuaJebgZ5vcIJ7Vfzez6maJiEjnv8JOnaXpZZSAt2J6cFFtStGGyLEp(DBBM3WkJyJ8aJqwLSybgKo34Tonen0zposV)E4snIQQ5fD4dtX7aY4GnpqgFofK2n(u88Kre6Ze6O10GJNJo4DHid8J6R5hswSA2tl8jrDMC8TcSXTtqdg91w6NJUd)IxbjuLUTaTct7TsqBvEW(63RF6H8tyVWjZF940EMmlCNj))IiFFURloEjLU8X1Z)NhOxiEMvXlHU0YNOlMNMWiBfYYTGQ7Bddj5)UqgwP5EjpoO43c0w5K91xEf3A)lRwuY)bJizu1SLJy0NJzgXVAfQ8Jqwge)vFte07lB6h17QK4jaGbLyTVtppLmFAsicb6pR150QL7egyy6I9oxFbXgdmYcJWGbps6YWTXPxJ6mIsaVbO4fAEO9ZliWEXmk0NkTb5x2fDJWgY4oUVVrt3cTFydRfbri)mYNSD3do20z9Q8ZjTUoSffLgJdHKGZ)(Ygh2ccXUqCteqC)YJS(TZZq6mu8KjRtssrPHf2byW9yzyXR2il73rbnjR38Ezbo4JZBhEhvPkKx0)HryHrXR(x4EOgin6BHkzS2uiWLB40gJepikEWWbaRSd8zymIy2V)