Tweaks to conditions tab styling
Stanzilla opened this issue ยท 7 comments
Our problems:
As a first measure, rename all Glow Conditions to have the same name as their Display
tab counterpart
Visibility
=>Show Glow
Do you have direct control over the order of the elements in that drop down? If so then also putting Visibility/"Show Glow" at the top would be a good idea. That setting is lost in the mix right now, not only because of the slightly obscure name.
I think that making the visibility property the default one would probably be the most effective.
The name change is already merged https://i.imgur.com/QZ1yRzQ.png
I don't know what can be done with ace dropdown regarding item order, but @emptyrivers suggestion to auto select "Show Glow" when selecting "! Glow" sound doable.
As I recall, AceConfigDialog sorts select and multi select widgets via the key AKA the internal value we store into data. So, changing the order is possible but may require a migration or at least some extra moving parts, depending on how we choose to do it.
The TwoColumnDropDown internally sorts the list:
- Meaning since it's our widget, we could sort in any way we would want.
- And second, a lot of code in ConditionOptions.lua could now be simplified, because it assumed that the control did not sort by displayname (which is the ace default).
I think selecting by default is even better though, that's a great insight.