WeakAuras

WeakAuras

206M Downloads

WA isn't working with LibClassicCasterino

bgfds opened this issue ยท 7 comments

commented

Auras are not being cleared on "UNIT_SPELLCAST_FAILED", instead the aura will remain active after being told by LibClassicCasterino that the unit isn't casting.

commented

Still doesn't seem to be working, overwrote my prototypes.lua with the updated one, restarted my game, same issue

https://streamable.com/qu5zs

commented

My tests show there is no CLEU event matching UNIT_SPELLCAST_INTERRUPTED
But LibClassicCasterino has a workaround for testing if cast was interrupted by checking GetUnitSpeed on enemy players every frames.
My tests on friendly players doesn't work but friendly units are not supported from what i understand of the lib code (this could be fixed), sadly i don't have 2 accounts to test this with players from both faction.

commented

I am alliance in my video, testing on a horde second account. LibClassicCasterino works with the creators own addon NugCast, I've already discussed this with him because initially I thought it was an issue on the Libs end. I tested v17, 19 and 20 of the Lib with WA, all of which work with NugCast. None work with WA.

All other castbars are also using this "hack" of GetUnitSpeed and have it working.

commented

I don't see areason it work with nugcast and not with weakauras.
I need find someone to test this with.

commented

I did some testing. Issue is that not all cast event are added into internal_events here
https://github.com/WeakAuras/WeakAuras2/blob/master/WeakAuras/Prototypes.lua#L5181
Everything other than these 3 gets filtered out

commented

Yup i could properly test this with a friend this morning and made a proper fix.

commented

The author of the Lib pointed me to

if event == "UNIT_SPELLCAST_STOP"
and said it might have something to do with this, but adding
or event == "UNIT_SPELLCAST_FAILED"

doesn't fix the issue