Updating Issue with Groups
Breakerzeus opened this issue · 6 comments
Describe the bug
If you update a group with Weakauras in it from Wago, the option to "update the group" is missing.
This works with single Auras copied from Wago, but if you put the same Aura into a group and try to update it then the option is missing. I tried it with 2 Versions of the same Aura (changed the Spell ID). One time I tested it without a Group, just the single WA. The second time I put the WA into a group and tried the same procedure.
Do you have an error log of what happened?
No log
To Reproduce
Steps to reproduce the behavior:
ISSUE:
- Go to Wago.io
- Copy Import String of Version 1.0 UpdateTestGroup: https://wago.io/85SnqXBux/1.0.0
- Import to WoW
- Copy Import String of Version 2.0 UpdateTestGroup: https://wago.io/85SnqXBux
- Import to WoW --> No option to update the group
Proof that it works without Group:
- Go to Wago.io
- Copy Import String of Version 1.0 UpdateTestSingle: https://wago.io/8LTES0mZg/1.0.0
- Import to WoW
- Copy Import String of Version 2.0 UpdateTestSingle: https://wago.io/8LTES0mZg
- Import to WoW --> Update Option available
Screenshots
Try updating Group:
Try updating Single:
Did you try having WeakAuras as the only enabled addon and everything else (especially something like ElvUI) disabled?
yes
Which version of WeakAuras are you using?
2.18.1
Are you on World of Warcraft Classic or Retail?
- Classic
- Retail
- Shadowlands
Was it working in a previous version? If yes, which was the last good one?
Additional Info
-
Wago-Link GroupWA: https://wago.io/85SnqXBux
-
Wago Link SingleWA: https://wago.io/8LTES0mZg
Yes, this system was indeed designed so that a group import will only update the group (and any children), and a single aura import will only update an aura which is not a member of a group.
But exaclty that does not work. If I import a group, then the group AND the children should be updated, shouldn't it?
Just in case you misunderstand this: I import a WA that is in a group. then this group is updated on wago and i like to import it as well. That is the case where it should give me the option to update. I want to update the exact same package that I imported a while ago, just an updated one.
I just remembered, there even were options to add new auras or remove auras that where not in the updated package on wago anymore. So that seems to be working like you wanted if there is this option. I can't understand why this should be not wanted now.
EDIT: Just for the understanding which impact this has: if you download a whole raid package from Reloe or someone else, you can't update it. You have to delete the old one and then you can import it as new package. All your settings (kick rotations, positionings) are all gone.
Sorry but this cannot be intended.
EDIT2: After reading through #1512 I want to remind once more: I do not want to update multiple auras in more than one group.
I just want to update the one package I already have in an older version.
Wait what? So it's intended to not let you update whole Packages? So it was a Bug that stayed in the whole Addon until now? Sorry but i doubt that, seriously.
Wait what? So it's intended to not let you update whole Packages? So it was a Bug that stayed in the whole Addon until now? Sorry but i doubt that, seriously.
Yes, this system was indeed designed so that a group import will only update the group (and any children), and a single aura import will only update an aura which is not a member of a group. This was done to avoid confusion in the scenario where certain auras published by one user are often republished in groups by other users. If we naively updated auras that matched the ones being imported, then importing one group might cause breaking changes to an entirely unrelated group, with no good way to realize what exactly caused that change.
No, the solution isn't perfect and we knew that when it was being developed. Perhaps in the future we might develop an improvement, but for now this is a deliberate limitation.
