Todo: Switch back to LibRangeCheck-2.0 upstream version once https://www.wowace.com/projects/librangecheck-2-0/issues/15 is fixed.

Todo: Switch back to LibRangeCheck-2.0 upstream version once https://www.wowace.com/projects/librangecheck-2-0/issues/15 is fixed.

Issue was solved upstream 5 months ago, it doesn't have the few spells we added in our fork.
https://github.com/tukui-org/ElvUI/tree/development/ElvUI/Libraries/Core/LibRangeCheck-2.0 is more maintained but it doesn't have it's own project, what about merge elvui version with our fork?

Well should we submit our changes as a PR on upstream then? And ask for permissions?

Upstream is hosted on wowace subversion repository, i don't know if that is possible.

Right, does the maintainer respond at all to messages?

His last activity in comments is from Jun 14, 2020, no activity in ticketing system, but they fixed issue reported by Stan and there are a few updates https://www.curseforge.com/wow/addons/librangecheck-2-0/files mostly toc update i guess but i didn't check

I'll check what dbm & bw do for their rangecheck..

A friendly fork is much better.

Both use their own implementation
https://github.com/DeadlyBossMods/DBM-Unified/blob/master/DBM-Core/DBM-RangeCheck.lua
https://github.com/BigWigsMods/BigWigs/blob/master/Plugins/Proximity.lua

I suggest we continue using our fork, and merge Elvui's one,

They changed MAJOR_VERSION = "LibRangeCheck-2.0-ElvUI" to not conflict with the upstream version i guess.
It double the load of rangechecking for people using both WeakAuras (or any other that use the lib) and Elvui.
I think it's best to keep their change of MAJOR_VERSION if we do use it.
And it's kinda the same situation with LibCustomGlow https://github.com/tukui-org/ElvUI/commits/development/ElvUI/Libraries/Core/LibCustomGlow-1.0/LibCustomGlow-1.0.lua, but didn't change MAJOR_VERSION there.

We use https://github.com/WeakAuras/LibRangeCheck-2.0 now, i think we need change name to avoid problems if original author make a sudden update on wowace, but it's not a topic for this ticket.

Its updated but also on wow ace there is a comment to change one line that fixes it independently

indeed but this version is less accurate than our now