WeakAuras

WeakAuras

206M Downloads

Latest commit breaks WA

Opened this issue ยท 8 comments

commented

Is your feature request related to a problem? Please describe.
The addition of PickupContainerItem to the forbbiden functions table breaks functionality in WAs that I have developed and are broadly used.

Describe the solution you'd like
Remove PickupContainerItem from the forbidden list.

Describe alternatives you've considered
I am not aware of any workarounds for this issue.

Additional context
I understand the security issue and risk involved and why the functions were added but is including DeleteCursorItem not satisfactory enough?

8cb556b

commented

Tagging @nullKomplex as you're the author of the commit.

commented

You didn't even describe the aura nor linked it.

commented

Here is an example of one of my WAs that is broken by this change. https://wago.io/rtDSk1EUl

This WA is used to fix an issue where the base game isn't able to equip 2 weapons of the same name.

commented

So the problem here is that it's the Internet and everyone abuses everything and that's why we can't have nice things. I do see your aura as a valid use-case but sadly I'd rather have us protect more people by blocking these API. We are in talks with Blizzard to potentially make this better but that might take a while and some convincing.

commented

Okay I read that too fast, just unblocking PickupContainerItem sounds okay to me...

commented

@Stanzilla What is the rationale behind reinstating PickupContainerItem() but not PickupInventoryItem()?

commented

nothing, I just did not commit it yet

commented

Based on the discussion already in the discord, just adding this here for clarity - DeleteCursorItem() is the only function that can cause irreparable damage.
Reinstating both Pickup API functions should be considered