Description

First this issue needs to be fixed: #3234

Because Seal of the Crusader is a special case because it could be exploited, the attack speed change of it is snapshotted.
That means that the effect is only applied and/or removed at the start of a new swing. This is so that no one can pop it after a swing, use the attack speed bonus dureing the swing and than turn it of before the swing hits so that the damage reduction dosnt effect the hit.

That means that this special case has to be handled seperatly.
This video is made with the fixes, stated in #3234 allready included:
https://streamable.com/2auzok
When activating it mid swing, the swing takes longer than the swing timer shows, when removing it the swing gose of before the swing timer is done.

WeakAuras Version

WeakAuras 3.5 and 3.6

World of Warcraft Flavor

The Burning Crusade

Tested with only WeakAuras

• Yes
• No

Lua Error

No response

Reproduction Steps

1. Start auto attacking a target
2. Pop Seal of the crusader mid swing / Remove Seal of the crusader mid swing
3. See how the swing timer shows the wrong timing

Last Good Version

No response

Screenshots

No response

Export String

No response

Well, how can we figure out the correct swing time then?

So at step 2, after applying Seal of the Crusader, UnitAttackSpeed returns wrong information?

Basically thats how you can see it yes, because the changes are actually not applied until after the next swing lands.
(But again, this needs to be fixed first #3234)

So basically with the way the current system works, it would be easyest to write a wrapper for UnitAttackSpeed("player"). To observe if SotC is applied, you can use the combat log event SPELL_AURA_APPLIED. The wrapper for UnitAttackSpeed("player") would have to calculate the real attack speed based on the current attack speed UnitAttackSpeed("player") and the informations about the if SotC is present and if a swing has allready applied or removed the attack speed change fromm it.

That sounds more like a wow bug then something we should support.

But the "bug" will not be fixed by blizz :D
So having a correct swing timer is the goal i think, right?
Than this must be resolved

If no one dose it until in like 2-3 weeks, i will probabyl have the time myself to do it.

I'm closing this ticket there is already #3234 and we don't need multiple tickets for related issues.

Please reopen that issue.
Its not related to the fix presented in #3234.
It just makes sence to fix that issue (#3234) first, before trying to fix this issue with SotC.
But this issue here needs a completly seperate and different fix than the one presented in #3234

No, one ticket for swing timer is enough.

The fix of #3234 will not fix this problem, if this problem is included in #3234, that would mean that #3234 could not be closed when the error there is fixed. This issue here is a special case and the fix is not reltaed to #3234. As you can read in this threat it has to do with wrong values from UnitAttackSpeed("player"). If anyone wants to fix this issue, they can do that without it having anything to do with #3234. Thats why i think having 2 seperate issues that can be closed on completion is the better way to go. Atm, one wouldnt find an issue related to SotC and would probably open a new one.