DBM Announce trigger type not triggering as of DBM 2.5.31
garrymullins opened this issue ยท 2 comments
Description
When using a trigger type of "Other Addons" with sub-type of "DBM Announce", the trigger no longer fires when a DBM Announce event occurs.
This trigger type worked with DBM 2.5.30 and prior, but as of 2.5.31 it no longer triggers.
The easiest way to test this is to zone into Hyjal Summit and start the Hyjal event, which fires a DBM Announce event but the DBM Announce trigger type no longer detects it.
WeakAuras Version
3.7.16
World of Warcraft Flavor
The Burning Crusade
Tested with only WeakAuras
- Yes
- No
Lua Error
Normally with the DBM Announce trigger type defined in a trigger you can see the DBM Announce event firing in "/eventtrace", but you don't see this.
Reproduction Steps
Proper Behaviour
- Zone into Hyjal Summit (or some other instance that has easily accessible DBM Announce events for testing) with DBM 2.5.30 installed and the latest version of WeakAuras.
- Create a WA with an "Other Addons" > "DBM Announce" trigger type defined. For testing purposes select Message and Contains, and then just type in "Wave" for the message. You can set a duration to see that the WA triggers.
- Activate the Hyjal event (or receive some DBM Announce message, wherever your chosen testing environment is)
- The WA should trigger when the DBM Announce event fires
- Additionally, when the DBM Announce event occurs, you should be able to see the "DBM_Announce" event under /eventtrace.
Failure Scenario
- Update to DBM 2.5.31 and repeat above steps, you will see the WA does not trigger and the "DBM_Announce" event does not show under /eventtrace
Last Good Version
3.7.16
Screenshots
No response
Export String
No response
I figured out the problem. Near line 7740 of DBM-Core.lua, the code is checking for a bunch of sound-related conditions and if those conditions are met, it returns the function and therefore doesn't proceed to fire the DBM_Announce event below.
For my own purposes, temporarily as a work-around, I moved the fireEvent("DBM_Announce" ... ) line above this IF statement that is exiting the function.
